Bug 236436 - sysutils/ansible: Depend on security/py-cryptography instead of security/py-pycrypto
Summary: sysutils/ansible: Depend on security/py-cryptography instead of security/py-p...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2019-03-10 01:38 UTC by John W. O'Brien
Modified: 2019-03-11 01:25 UTC (History)
3 users (show)

See Also:
lifanov: maintainer-feedback-

Attachments
sysutils/ansible: Switch to security/py-cryptography where possible (2.28 KB, text/plain)
2019-03-10 01:38 UTC, John W. O'Brien 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2019-03-10 01:38:15 UTC 
Created attachment 202758 [details]
sysutils/ansible: Switch to security/py-cryptography where possible

Changelog
=========

*   For ansible >= 2.4, prefer security/py-cryptography per upstream [0]
*   Bump PORTREVISION of affected slave ports


[0] https://github.com/ansible/ansible/blob/v2.4.0.0-1/CHANGELOG.md, "Minor changes", tenth item


QA
==

poudriere bulk succeeds for sysutils/ansible1@py27 and sysutils/ansible{23,24,25,26,}@py{27,35,36,37}
Comment 1 Nikolai Lifanov freebsd_committer freebsd_triage 2019-03-11 01:02:18 UTC 
This is great, thank you! However, I will use a different approach.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-03-11 01:05:30 UTC 
A commit references this bug:

Author: lifanov
Date: Mon Mar 11 01:05:25 UTC 2019
New revision: 495320
URL: https://svnweb.freebsd.org/changeset/ports/495320

Log:
  ansible: switch to security/py-cryptography

  For ansible >= 2.4, py-cryptography is preferred upstream.

  PR:		236436
  Reported by:	John W. O'Brien <john@saltant.com>

Changes:
  head/sysutils/ansible/Makefile
  head/sysutils/ansible23/Makefile
  head/sysutils/ansible24/Makefile
Comment 3 Nikolai Lifanov freebsd_committer freebsd_triage 2019-03-11 01:06:07 UTC 
Thank you for your report! I committed an alternative fix.
Comment 4 John W. O'Brien 2019-03-11 01:25:50 UTC 
(In reply to Nikolai Lifanov from comment #3)

You're welcome. I wasn't especially attached to the approach and will report if I notice anything amiss based on your patch.