Bug 236617 - irc/bitchx: Ensure paths to correct OpenSSL are used in build
Summary: irc/bitchx: Ensure paths to correct OpenSSL are used in build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-03-18 12:55 UTC by caf
Modified: 2019-03-19 15:05 UTC (History)
1 user (show)

See Also:
freebsd: maintainer-feedback+
koobs: merge-quarterly?

Attachments
Tested patch for port (745 bytes, patch)
2019-03-18 12:55 UTC, caf 		freebsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description caf 2019-03-18 12:55:59 UTC 
Created attachment 202955 [details]
Tested patch for port

When the default OpenSSL version is set to something other than base, the correct include path is not being used (so the package is compiled against the headers from the base version of OpenSSL, but linked against the ports version).

This is clearly bogus, and causes build failures on FreeBSD 11.2 when DEFAULT_VERSIONS is set to ssl=openssl111.

This bumps the PORTREVISION because even if it apparently compiles successfully with the wrong headers there could be some subtle breakage.
Comment 1 BitchX FreeBSD 2019-03-18 13:35:01 UTC 
This supplies the OpenSSL base where the configure script expects it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-03-19 15:05:36 UTC 
A commit references this bug:

Author: swills
Date: Tue Mar 19 15:04:33 UTC 2019
New revision: 496264
URL: https://svnweb.freebsd.org/changeset/ports/496264

Log:
  irc/bitchx: Use correct OpenSSL include path

  PR:		236617
  Submitted by:	caf@bitchx.org
  Approved by:	BitchX FreeBSD <freebsd@bitchx.org> (maintainer)

Changes:
  head/irc/bitchx/Makefile
Comment 3 Steve Wills freebsd_committer freebsd_triage 2019-03-19 15:05:54 UTC 
Committed, thanks!