Bug 236730 - x11/eaglemode: fix build with GCC-based architectures
Summary: x11/eaglemode: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-23 08:38 UTC by Piotr Kubaj
Modified: 2019-03-28 16:12 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)

Attachments
patch (361 bytes, patch)
2019-03-23 08:38 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-03-23 08:38:20 UTC 
Created attachment 203064 [details]
patch

LDFLAGS, when using ports GCC, has a space at the beginning, which eaglemode has problem with. Add correct LDFLAGS (without the space in the beginning) so that the port builds.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2019-03-28 16:08:50 UTC 
This is incorrect in many ways like you may not override LDFLAGS and you may not hardcode /usr/local. Code should be fixed instead to handle whitespace correctly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-03-28 16:09:56 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu Mar 28 16:08:53 UTC 2019
New revision: 497026
URL: https://svnweb.freebsd.org/changeset/ports/497026

Log:
  Don't generate empty arguments when parsing CFLAGS/CXXFLAGS/LDFLAGS

  PR:		236730
  Submitted by:	pkubaj@anongoth.pl

Changes:
  head/x11/eaglemode/files/patch-makers_unicc_plugins_unicc__gnu.pm