Created attachment 203275 [details] patch file - Update 1.3.2 -> 1.4.0 - While here, pet portlint Changelog: https://github.com/dunst-project/dunst/blob/cf7dec2989d365d6b4c7b54366f8fac8ab6c62cb/CHANGELOG.md QA: poudriere testport: OK (112a, 112i, 120a)
Created attachment 203456 [details] Update to 1.4.0. I did a few more changes due to the fact dunst build slightly different now. Also, `libnotify` was added to RUN_DEPENDS.
Created attachment 203457 [details] Update to 1.4.0. Minor fixes.
(In reply to Alexandre C. Guimarães from comment #2) Why the need for devel/libnotify dependency? dunst doesn't link to libnotify nor does it need notify-send.
Dunst doesn't work (show up) if libnotify is not installed.
Something else must be wrong then because libnotify is not a dunst dependency. Do you have a dunstrc (usually in ~/.config/dunst)?
Either way, please do not frivolously obsolete maintainer-approved patches.
Hm. Just now I learned about `dunstify` and it is/was not being installed.
And ever with `dunstify` installed its needs `libnotify`. https://github.com/dunst-project/dunst/blob/master/config.mk
dunstify needs libnotify yes [1], but not dunst. As dunstify is not getting installed, there's no need to libnotify dep. This has nothing to do with this partucular PR which is about bringing dunst version to 1.4.0. Please create a separate PR if you'd like dunsitfy to be included in dunst installation. [1] https://github.com/dunst-project/dunst/wiki/Dependencies
Created attachment 203459 [details] Update to 1.4.0. - update to 1.4.0. - add the missing `devel/libnotify` to LIB_DEPENDS - fix `dunstify` not being installed - switch to DISTVERSION - put DISTVERSIONPREFIX in correct order Thanks!
(In reply to Dmitri Goutnik from comment #9) Dunst needs libnotify otherwise it will not show up, and so would not be functional, and so broken. Dunstify not being installed is a defect; however that could be moved to OPTIONS if the maintainer prefer.
Comment on attachment 203459 [details] Update to 1.4.0. Thanks for your patch but the dependencies list is wrong. I'll submit an updated patch later with an option to install dunstify.
Created attachment 203461 [details] Update to 1.4.0. Same as previous but: - move `dunstify` to OPTIONS - move PLIST_FILES to pkg-plist - remove TEST_TARGET (not working anyway) @swills all credits go to the submitter: "Dmitri Goutnik". Thank you. :-)
Created attachment 203482 [details] patch file - Update 1.3.2 -> 1.4.0 - Switch to DISTVERSION - Fix extract_urls regex (also fixes tests) [1] - Add DUNSTIFY option QA: poudriere testport: OK (120a, 120i) [1] https://github.com/dunst-project/dunst/pull/622
I've tested your patch without the dunstify option, libnotify was removed after a `pkg autoremove` since I don't need it for anything else, and dunst doesn't work anymore.
Sigh. Again, dunst doesn't need libnotify to function. It's a notification *server* and libnotify provides client functionality. $ ls -la /usr/local/lib/libnotify* ls: /usr/local/lib/libnotify*: No such file or directory $ pkg info libnotify pkg: No package(s) matching libnotify See comment #5. Something else on your system needs libnotify to be able to send notifications but doesn't record it as a dependency.
Created attachment 203493 [details] Update to 1.4.0 Same as previous but: - bring closer to head due to fixes on test phase. One test still fail.
Dmitri, I think you don't know what RUN_DEPENDS is. First that was not to do with the software linking to it, inclusive because RUN_DEPENDS just happens *after* the build process. RUN_DEPENDS is about the necessary software to make the port *run* properly, and as you said dunst is a notification server and that has no purpose without a client, and libnotify is the de facto standard notification client. Also, if you investigate the dunst source code you will see it is purposely designed to work with *notify-send*. That said, thank you for your work and patches; however this port update will *not* be committed without the proper RUN_DEPENDS with libnotify.
(In reply to Alexandre C. Guimarães from comment #18) Alexandre, I'm not going to engage in further discussions about libnotify requirements. If you insist on it to be added, you may as well take over port maintainership.
Thank you.
I will get the maintainership, are you releasing it?
Created attachment 203498 [details] Update to 1.4.0. Taking the maintainership as suggest by the current maintainer. Thanks.
Created attachment 203499 [details] Update to 1.4.0. I did a compromise, removed libnotify from RUN_DEPENDS but added a `pkg-message` informing you need sysutils/libnotify in order to have the notifications showing. Thanks.
(In reply to Alexandre C. Guimarães from comment #18) > RUN_DEPENDS is about the necessary software to make the port *run* properly, and as you said dunst is a notification server and that has no purpose without a client, and libnotify is the de facto standard notification client. Hi Alexandre, I think you are confused about the purpose of RUN_DEPENDS. Packages that are needed during the run should be listed there. This may include external executables that are run by the package, shared libraries dynamically loaded by the package, fonts or some data files needed by the package to function. But if the package is a server, installing things needed for its clients to function isn't a responsibility of the package. There are many examples of this in the ports tree, For example, MySQL server and client are separate packages not requiring each other. Regards, Yuri
(In reply to Alexandre C. Guimarães from comment #21) Sure. Please take over and do what you think is best. > however this port update will *not* be committed without the proper RUN_DEPENDS with libnotify I believe I already made all the arguments above and twisting my arms like this doesn't give me much incentive to maintain this port any longer.
(In reply to Dmitri Goutnik from comment #25) Please see comment #23.
Now, re-reading the whole tread I do recognize I was too stringent given the informal nature of the project. Sorry about that.
Dunst is a D-Bus service that implements the org.freedesktop.Notifications spec [1]. libnotify is just one possible client implementation (here's a different one: [2]) so of course a libnotify run dependency is not needed for this port as Yuri and Dmitri have already pointed out. Adding a note to pkg-message to install libnotify would be more confusing than helpful IMHO. This PR seems to be stalled now. Can we please land this? If this needs a new maintainer now I'd be ok with taking the port. [1] https://developer.gnome.org/notification-spec/ [2] https://github.com/hoodie/notify-rust
@tobik I could maintain the port, no problem, but given the past disagreement I had, I suppose that would be more productive if you take this bug then. Cheers.
ALL_TARGET=all is probably not needed.
A commit references this bug: Author: tobik Date: Sun Apr 14 18:26:07 UTC 2019 New revision: 498946 URL: https://svnweb.freebsd.org/changeset/ports/498946 Log: sysutils/dunst: Update to 1.4.0 Changes: https://github.com/dunst-project/dunst/blob/cf7dec2989d365d6b4c7b54366f8fac8ab6c62cb/CHANGELOG.md PR: 236916 Submitted by: Dmitri Goutnik <dg@syrec.org> (maintainer) Changes: head/sysutils/dunst/Makefile head/sysutils/dunst/distinfo
Committed the last maintainer approved patch. Thanks!