Bug 237004 - sysutils/freeipmi: fix build on powerpc64
Summary: sysutils/freeipmi: fix build on powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-04 07:33 UTC by Piotr Kubaj
Modified: 2019-04-04 23:57 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch (1.40 KB, patch)
2019-04-04 07:33 UTC, Piotr Kubaj 		no flags Details | Diff
v2 (1.44 KB, patch)
2019-04-04 07:34 UTC, Piotr Kubaj 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-04 07:33:44 UTC 
Created attachment 203366 [details]
patch

This port doesn't invoke x86 assembly (at least not on powerpc64). It only requires including machine/pio.h in libfreeipmi/driver/ipmi-kcs-driver.c for inb and outb functions. It's probable that other platforms that are marked as broken can also just include machine/pio.h and this may unbreak them, but I don't have hardware using those architectures.

Tested on powerpc64 and amd64.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2019-04-04 07:34:49 UTC 
Created attachment 203367 [details]
v2

Add correct patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-04 23:57:24 UTC 
A commit references this bug:

Author: sunpoet
Date: Thu Apr  4 23:56:36 UTC 2019
New revision: 497890
URL: https://svnweb.freebsd.org/changeset/ports/497890

Log:
  Fix build on powerpc64

  PR:		237004
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/sysutils/freeipmi/Makefile
  head/sysutils/freeipmi/files/patch-libfreeipmi-driver-ipmi-kcs-driver.c
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-04-04 23:57:32 UTC 
Committed. Thanks!