Created attachment 203478 [details] svn diff mail/sympa to 6.2.42 Port changes: * update dependencies list (missing and deprecated) * avoid warnings * upstream release Upstream changes: * reversible encryption of password storage in database was dropped * Authorization schearios: The "default" scenario files named *.default (regular file or symbolic link) are no longer available * Files for message footer and header were renamed to message_footer and message_header * Complete list: https://github.com/sympa-community/sympa/blob/6.2.42/NEWS.md Upgrade notes: https://sympa-community.github.io/manual/upgrade/notes.html#from-versions-prior-to-6242 Poudriere and production-tested :)
Hi Geoffroy, thank you for the patch. Unfortunately there is an error before the build process can start: > =======================<phase: check-sanity >============================ > ===> License GPLv2 accepted by the user > ====> You cannot select multiple options from the FRONTEND radio > =====> Only one of these must be defined: APACHE FASTCGI >*** Error code 1 > > Stop. > make: stopped in /usr/ports/mail/sympa This is caused by the line "APACHE_IMPLIES=FASTCGI" and we might need to do following changes: - Add OPTIONS_MULTI=FRONTEND - Remove FRONTEND from OPTIONS_RADIO - Convert the variable "OPTIONS_RADIO_FRONTEND" to "OPTIONS_MULTI_FRONTEND". If those changes are ok for you I'll apply them to my working copy.
Created attachment 203547 [details] svn diff mail/sympa Here it is. Additionnaly, I changed default to be FASTCGI and not APACHE, as this is not anymore the only way to make it work and it can be annoying to install apache when not desired… also reverted to simple OPTIONS for both. My poudriere liked it :)
(In reply to geoffroy desvernay from comment #2) Thank you for the updated patch. :) It builds fine and I did apply some minor fixes by removing some variables that are redundant now, e.g.: - CONFLICTS - SUB_LIST - PGSQL_VARS - MYSQL_VARS I have only one question before I'll open a pre-commit review: MYSQL is introduced as a new default option. The still current version of mail/sympa in the ports tree doesn't set a explicit dependency for the type of database. Is this intended or should we remove MYSQL from OPTIONS_DEFAULT?
I'm not sure about this... * The software needs a DB, and the dependency is "only" a perl DBD module (and C client) per DB type. * Sympa software can use more than one DB type (arbitrary queries to fill lists) sqlite by default could be nice, but I never tested sympa with sqlite, it may impose severe performance limits… I'm OK with any of: - letting mysql by default - setting sqlite by default (little lighter) - setting all (pgsql, mysql and sqlite) by default (only way to ensure it will work out of the box) Pick one :)
(In reply to geoffroy desvernay from comment #4) Alright, then let's use MYSQL as default and use SQLITE as fallback. The patch is now available as pre-commit review and once it gets approved by one of my mentors the update can land: https://reviews.freebsd.org/D19929
A commit references this bug: Author: kai Date: Thu Apr 18 17:40:55 UTC 2019 New revision: 499282 URL: https://svnweb.freebsd.org/changeset/ports/499282 Log: mail/sympa: Update to 6.2.42 * Introduce new option for SQLite support * Modernize the options regarding the database types * Define MYSQL and FASTCGI as new default options While I'm here: * Fix the license and add the location to the license file * Convert the usage to GH_TUPLE to USE_GITHUB/GH_ACCOUNT as GH_TUPLE is not meant for the default distribution file * Remove no longer required CONFLICTS because mail/sympa5 has been removed from the Ports tree in 2012 * Remove SUB_LIST because the variables are no longer referenced in one of the files defined in SUB_FILES * Sort variables a bit to place them to their intended locations Changelog since 6.2.36: * Built-in authentication: RC4 reversible encryption of password storage in database was dropped. * Format of session cookie was changed. Session cookies generated with earlier releases will be invalidated. * Authorization scenarios: The "default" scenario files named *.default (regular file or symbolic link) are no longer available. * Files for message footer and header were renamed to message_footer and message_header. * WWSympa: LDAP authentication will no longer perform search operation twice. Now it retrieves entry for the user by a search operation at once, then checks if account is available by a bind operation. * WWSympa: Feature of sympa_altemails cookie was removed. alternative_email_attribute parameter in auth.conf was deprecated. * Primary auth.conf, crawlers_detection.conf and trusted_applications.conf will be used by non-primary domains by default. Previously primary ones were omitted. * Tasks: Task files will be put in tasks subdirectory. Previously they were put in global_task_models or list_task_models subdirectory. Older task files will be automatically copied to new places during upgrading process. * Oracle Database: There is a change on usage of db_host parameter. * WWSympa: Login form was refactored. Some templates including web_tt2/login.tt2 and web_tt2/login_menu.tt2 were changed. * Now the lists with bounce addresses can not be created. Addresses with local part "bounce" or prefix "bounce+" are used for bounce management and should not be used as list addresses. Implemented enhancements: * Refactoring on mail templates * Feature request: add a "global" mail signature * Adding ARC support Fixed bugs: * SSO session refresh won't reset WWSympa's session * Long email addresses in system messages might be folded * Moderation process on the lists with obsoleted parameter host fails * File extension may contain spaces by using gettext_strftime() * WWSympa: Loading home page takes long time * WWSympa: Older CSS files would be cleared Closed issues: * Bug in logic. Password is in md5 format, not rehashing Merged pull requests: * Allow to use Gitlab CI https://github.com/sympa-community/sympa/blob/6.2.42/NEWS.md PR: 237108 Submitted by: Geoffroy Desvernay (maintainer) Approved by: miwi (mentor) Differential Revision: https://reviews.freebsd.org/D19929 Changes: head/mail/sympa/Makefile head/mail/sympa/distinfo head/mail/sympa/files/patch-Makefile.am head/mail/sympa/files/pkg-message.in head/mail/sympa/pkg-plist
Committed, thank you for the patch!