Bug 237177 - net/libdnet: Unnecessary dependency added in r498511
Summary: net/libdnet: Unnecessary dependency added in r498511
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-10 09:39 UTC by Christian Ullrich
Modified: 2023-08-18 02:54 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (onatan)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ullrich 2019-04-10 09:39:12 UTC
r498511 is supposed to "Fix build when devel/check is installed" with regard to net/libdnet. It does this by adding the unit test framework devel/check as a DEPENDS, so that installing libdnet from packages will always pull in the entirely unnecessary devel/check as well.

If installing devel/check is actually a valid fix for the underlying problem (unlikely but possible), it should be made a TEST_DEPENDS or BUILD_DEPENDS.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-05-01 07:32:03 UTC
A commit references this bug:

Author: tobik
Date: Wed May  1 07:31:56 UTC 2019
New revision: 500582
URL: https://svnweb.freebsd.org/changeset/ports/500582

Log:
  net/libdnet: Drop bogus libcheck run dependency

  It was added in r498511 to fix the build when devel/check is installed
  in the environment.  It is not used for anything other than building
  a couple of tests that are never run or installed.  Instead just
  pass --without-check to configure to disable use of it.

  PR:		237177
  Reported by:	Christian Ullrich <chris@chrullrich.net>

Changes:
  head/net/libdnet/Makefile
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-05-01 07:32:22 UTC
Thanks. Fixed!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-08-18 02:54:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37a49e59eee1bd6da8ca156cdb1a61c545fe7440

commit 37a49e59eee1bd6da8ca156cdb1a61c545fe7440
Author:     Alessandro Sagratini <alessandro.sagratini@gmail.com>
AuthorDate: 2023-08-17 12:52:35 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2023-08-18 02:50:52 +0000

    devel/{py-oci,oci-cli}: update py-oci to 2.110.1 and update oci-cli to 3.31.0

    PR:             237177
    Changes:        https://github.com/oracle/oci-cli/releases/tag/v3.31.0

 devel/oci-cli/Makefile | 4 ++--
 devel/oci-cli/distinfo | 6 +++---
 devel/py-oci/Makefile  | 2 +-
 devel/py-oci/distinfo  | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)