Bug 237226 - games/scummvm-tools: fix build with GCC-based architectures
Summary: games/scummvm-tools: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-12 17:54 UTC by Piotr Kubaj
Modified: 2019-04-30 13:50 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (lme)


Attachments
patch (467 bytes, patch)
2019-04-12 17:54 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-12 17:54:11 UTC
Created attachment 203619 [details]
patch

This port needs C++11. It also uses the compiler specified by wx-config --cxx, so we need to patch that first.

Also add --enable-verbose-build to CONFIGURE_ARGS.

Tested on powerpc64 and amd64.
Comment 1 Lars Engels freebsd_committer freebsd_triage 2019-04-20 13:17:59 UTC
Thanks! Feel free to commit it!
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-04-21 04:41:42 UTC
Maintainer has approved: over to submitter who is now committer.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-30 13:47:35 UTC
A commit references this bug:

Author: pkubaj
Date: Tue Apr 30 13:47:07 UTC 2019
New revision: 500491
URL: https://svnweb.freebsd.org/changeset/ports/500491

Log:
  games/scummvm-tools: Add USES=compiler:c++11-lang, enable verbose build

  Add USES=compiler:c++11-lang to fix linking on GCC architectures.

  Also add --enable-verbose-build to generate more messages during build.

  PR:		237226
  Approved by:	lme (maintainer), mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D19988

Changes:
  head/games/scummvm-tools/Makefile