Bug 237284 - devel/llvm70 and devel/llvm80: Incomplete lit installation
Summary: devel/llvm70 and devel/llvm80: Incomplete lit installation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-14 19:39 UTC by Gleb Popov
Modified: 2019-04-17 18:08 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brooks)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Popov freebsd_committer freebsd_triage 2019-04-14 19:39:09 UTC 
llvm-lit has `cat` command, which tests can use. It is implemented in ${WRKSRC}/utils/lit/builtin_commands/cat.py, but this file isn't installed by the package.

It would be great if at least llvm70 and llvm80 would install this file.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-04-17 16:20:49 UTC 
A commit references this bug:

Author: brooks
Date: Wed Apr 17 16:20:07 UTC 2019
New revision: 499184
URL: https://svnweb.freebsd.org/changeset/ports/499184

Log:
  Fix the installation of llvm-lit's "cat" utility.

  On llvm80, also disable discovery of libz3 to avoid an untracked
  dependency when math/z3 is installed during a manual build.

  PR:		237284
  Reported by:	arrowd
  Sponsored by:	DARPA, AFRL

Changes:
  head/devel/llvm70/Makefile
  head/devel/llvm70/pkg-plist
  head/devel/llvm80/Makefile
  head/devel/llvm80/pkg-plist
Comment 2 Brooks Davis freebsd_committer freebsd_triage 2019-04-17 16:22:26 UTC 
Thanks for the report.  Sorry for the delay, I started on the patch when you email'd me and then got distracted by personal issues.
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2019-04-17 18:08:44 UTC 
No problem, thanks for fixing that!