Created attachment 203687 [details] patch for files/puppetserver.in puppetserver_java_opts is noted as a valid option in the comments/description of the rc-script for puppetserver, but is never used as a variable in the start-up command. I've attached a patch for it, if needed.
Hi. Thank you for the patch. I can take a closer look in the next few evenings and work to get this tested and committed.
I've put up a review for this and tested it. Will commit once approved.
Link to review: https://reviews.freebsd.org/D20010 Thanks Zach!
Nice, thanks! I see that there is the same "issue" with databases/puppetdb5 and puppetdb6, which I think you also maintain, perhaps a review could be created for it as well, or should I create a new bug report here for it? (puppetdb_java_opts is missing in the command_args, but is noted in the rc-script)
Good catch! I think we can handle all this in this PR and update the review accordingly?
A commit references this bug: Author: zleslie Date: Tue Apr 30 18:12:02 UTC 2019 New revision: 500514 URL: https://svnweb.freebsd.org/changeset/ports/500514 Log: Ensure java options are utilized Without this change, the doc for the rc script references the ability pass Java opts to the start command, but those references are never used. Here we ensure that thse options are respected and implemented. PR: 237295 Reviewed by: mat(mentor),romain Approved by: mat(mentor),romain Differential Revision: D20010 Changes: head/databases/puppetdb5/Makefile head/databases/puppetdb5/files/puppetdb.in head/databases/puppetdb6/Makefile head/databases/puppetdb6/files/puppetdb.in head/sysutils/puppetserver5/Makefile head/sysutils/puppetserver5/files/puppetserver.in head/sysutils/puppetserver6/Makefile head/sysutils/puppetserver6/files/puppetserver.in
Thanks for the report! A fix for this has been committed.