Bug 237327 - dns/sshfp: fails to parse arguments
Summary: dns/sshfp: fails to parse arguments
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-17 09:15 UTC by Dave Cottlehuber
Modified: 2019-05-05 15:23 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Cottlehuber freebsd_committer freebsd_triage 2019-04-17 09:15:08 UTC
this script seems to want to do AXFR all the time, maybe a logic error. Nor does it even handle its own `sshfp -v` successfully.

SyntaxError: invalid syntax
$ sshfp -v
  File "/usr/local/bin/sshfp", line 203
    raise dns.exception.FormError, domain
                                 ^
SyntaxError: invalid syntax
$ sshfp -d freebsd.org
  File "/usr/local/bin/sshfp", line 203
    raise dns.exception.FormError, domain
                                 ^
SyntaxError: invalid syntax
$ pkg info sshfp
sshfp-1.2.2_4
Name           : sshfp
Version        : 1.2.2_4
Installed on   : Wed Apr 17 08:58:31 2019 UTC
Origin         : dns/sshfp
Architecture   : FreeBSD:12:*
Prefix         : /usr/local
Categories     : security dns
Licenses       : GPLv2
Maintainer     : ehaupt@FreeBSD.org
WWW            : https://github.com/xelerance/sshfp
Comment        : Generate SSHFP DNS records from knownhosts files or ssh-keyscan
Annotations    :
	flavor         : py36
	repo_type      : binary
	repository     : FreeBSD
Comment 1 Emanuel Haupt freebsd_committer freebsd_triage 2019-04-17 11:59:37 UTC
The default python version was recently changed from 2.7 to 3.6. It turns out this port did not age well with age. The last update from upstream is from 2015.

For now I've marked the port for 2.7 only. I've managed to patch it to work with python 3.6 but that needs a bit further testing.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-17 12:25:43 UTC
A commit references this bug:

Author: ehaupt
Date: Wed Apr 17 12:25:16 UTC 2019
New revision: 499174
URL: https://svnweb.freebsd.org/changeset/ports/499174

Log:
  - This port does not yet work with python 3
  - While here pacify portlint

  PR:		237327 (based on)
  Submitted by:	dch@freebsd.org

Changes:
  head/dns/sshfp/Makefile
  head/dns/sshfp/distinfo
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2019-05-05 15:23:49 UTC
Port is now marked python 2.7 only.