Bug 237460 - devel/rubygem-tty: Remove bundler dependency pin on bundler < 2
Summary: devel/rubygem-tty: Remove bundler dependency pin on bundler < 2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks: 235796
  Show dependency tree / graph
 
Reported: 2019-04-22 09:06 UTC by Koichiro Iwao
Modified: 2019-04-23 17:56 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch (2.46 KB, patch)
2019-04-22 09:06 UTC, Koichiro Iwao 		no flags Details | Diff
patch (1.70 KB, patch)
2019-04-23 09:45 UTC, Koichiro Iwao 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Koichiro Iwao freebsd_committer freebsd_triage 2019-04-22 09:06:31 UTC 
Created attachment 203888 [details]
patch

To adapt upcoming bundler update to 2, bundler dependency pin needs to be loosened as well as bug 237384. Confirmed it works well with bundler 2.

Without this patch, it fails to build.

====> Running Q/A tests (stage-qa)
Error: RubyGem dependency bundler ~> 1.16 is not satisfied.
Error: RubyGem dependency bundler < 2.0 is not satisfied.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/rubygem-tty
=>> Error: stage-qa failures detected
build of devel/rubygem-tty | rubygem-tty-0.9.1_1 ended at Mon Apr 22 18:02:22 JST 2019
build time: 00:00:24
!!! build failure encountered !!!
[00:02:58] Error: Build failed in phase: stage-qa
Comment 1 Matthias Fechner freebsd_committer freebsd_triage 2019-04-23 07:08:35 UTC 
If a dependency is defined as ~> 1.16 that means that you can only increase the last part of the version without breaking it.
So 1.17, 1.18, ... is ok, but not 2.x.
In this case you have to change ~> 1.16 to >= 1.16.

You maybe should try that first upstream.
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2019-04-23 07:15:51 UTC 
Just updating to the latest release might solve the problem, I'll check it.
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2019-04-23 08:58:19 UTC 
Ah, 0.9.1 is already the latest version. Anyway, I'll try in upstream.
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2019-04-23 09:45:13 UTC 
Created attachment 203916 [details]
patch

Found an upstream PR: https://github.com/piotrmurach/tty/pull/51
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-04-23 17:54:45 UTC 
A commit references this bug:

Author: sunpoet
Date: Tue Apr 23 17:53:29 UTC 2019
New revision: 499783
URL: https://svnweb.freebsd.org/changeset/ports/499783

Log:
  Relax bundler dependency

  - Bump PORTREVISION for package change

  PR:		237460
  Submitted by:	meta

Changes:
  head/devel/rubygem-tty/Makefile
  head/devel/rubygem-tty/files/patch-gemspec
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-04-23 17:56:31 UTC 
Committed. Thanks!