Created attachment 203926 [details] Patch to update to version 1.5.2 This patch update the sysutils/google-compute-engine-oslogin to the latest upstream version. The file 'files/patch-bin_google__oslogin__control' was removed since those modifications were already applied by the upstream.
Created attachment 203927 [details] poudriere logs using freebsd 11.2
Created attachment 203928 [details] poudriere logs using freebsd 12
Created attachment 204148 [details] google-compute-engine-oslogin-1.5.2.patch / Patch from 1.4.3 to 1.5.2 (In reply to Lucas Kanashiro from comment #0) Hi Lucas, thank you for the patch. Something seems to have gotten mixed up there: Your patch is a diff against 1.5.0 but that version isn't in the Ports tree as there's still 1.4.3 of sysutils/google-compute-engine-oslogin . But I could make out the reason: Your patch in bug #236499 wasn't committed at all. Thus I merged that patch with the one in this PR. The actual state is now: - Update sysutils/google-compute-engine-oslogin from 1.4.3 to 1.5.2 - Change the MAINTAINER address - All patches in files/ were removed because they're merged by upstream - It compiles fine on all FreeBSD releases (amd64 + i386) I have attached the revised patch and if your co-worker Helen (the still maintainer) can give her approval for it, we can speed up the process.
Hi Kai, Thanks for your working merging those patches! Helen already approved the changes, can we move forward and commit those patches in the main ports tree?
A commit references this bug: Author: kai Date: Sun May 12 12:11:26 UTC 2019 New revision: 501379 URL: https://svnweb.freebsd.org/changeset/ports/501379 Log: sysutils/google-compute-engine-oslogin: Update to 1.5.2 * Pass maintainership to submitter * Remove all patches because they're merged by upstream While I'm here: * Pet portlint * Strip info from another shared library to level up port compliance Changelog since 1.4.3: * Fix alternate challenge section for two factor authentication. * Fix FreeBSD compatibility issues in the control file. * Use pam_group to provide users with default groups. * Add compat.h to support FreeBSD. * Exit immediately after a two factor authentication failure. * Add support for Google phone prompt challenges. PR: 237496 Submitted by: Lucas Kanashiro <lucas.kanashiro@collabora.com> Approved by: Helen Koike (previous maintainer) Changes: head/sysutils/google-compute-engine-oslogin/Makefile head/sysutils/google-compute-engine-oslogin/distinfo head/sysutils/google-compute-engine-oslogin/files/
Committed, thank you Helen and Lucas for your feedback! P.S.: Sorry for the small delay because it was a busy week for me.