Bug 237528 - lang/racket: state option dependencies, unbreak on i386
Summary: lang/racket: state option dependencies, unbreak on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jimmy Olgeni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-24 14:28 UTC by Martin Neubauer
Modified: 2019-11-26 11:23 UTC (History)
0 users

See Also:
olgeni: maintainer-feedback+

Attachments
changed port options (983 bytes, patch)
2019-04-24 14:28 UTC, Martin Neubauer 		no flags Details | Diff
unbreak building on i386 with jit enabled (908 bytes, patch)
2019-11-26 02:47 UTC, Martin Neubauer 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Neubauer 2019-04-24 14:28:44 UTC 
Created attachment 203967 [details]
changed port options

As enabling the jit is required for futures support, it seems reasonable that the ports system knows about this.

Conversely, without jit enabled, racket should build an run on i386 just fine. Therefore changing the option defaults should make the port available there again.

(One small caveat: At the moment I don't have a machine ready to test the situation on i386, but since that was the case when I did, I'm quite confident that it is not too difficult to confirm.)
Comment 1 Martin Neubauer 2019-11-26 02:47:19 UTC 
Created attachment 209437 [details]
unbreak building on i386 with  jit enabled
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-11-26 11:21:52 UTC 
A commit references this bug:

Author: olgeni
Date: Tue Nov 26 11:21:24 UTC 2019
New revision: 518462
URL: https://svnweb.freebsd.org/changeset/ports/518462

Log:
  lang/racket and lang/racket-minimal: make FUTURES depend on JIT.

  Set CFLAGS only for amd64 with JIT enabled, so as to unbreak i386
  (poudriere confirms.)

  PR:           237528
  Submitted by: m.ne@gmx.net

Changes:
  head/lang/racket/Makefile
  head/lang/racket-minimal/Makefile
Comment 3 Jimmy Olgeni freebsd_committer freebsd_triage 2019-11-26 11:23:08 UTC 
Thanks! \o/