Bug 237549 - textproc/htmltolatex: fix build with GCC-based architectures
Summary: textproc/htmltolatex: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-25 08:53 UTC by Piotr Kubaj
Modified: 2019-04-27 09:06 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback+

Attachments
patch (2.46 KB, patch)
2019-04-25 08:53 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (pi)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-25 08:53:01 UTC 
Created attachment 204000 [details]
patch

Add USES=compiler:c++11-lang.

Add include <cstring> and <strings.h> to CH2L.cpp.

Add include <cstring> to util.cpp.

Required to build with GCC (used on GCC architectures).

Tested on powerpc64 and amd64.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2019-04-25 10:31:47 UTC 
Looks file, please commit.
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2019-04-25 10:32:06 UTC 
Looks 'fine', not 'file'. argl
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-27 09:04:55 UTC 
A commit references this bug:

Author: pkubaj
Date: Sat Apr 27 09:04:30 UTC 2019
New revision: 500204
URL: https://svnweb.freebsd.org/changeset/ports/500204

Log:
  textproc/htmltolatex: fix build with GCC-based architectures

  Add USES=compiler:c++11-lang.

  Add include <cstring> and <strings.h> to CH2L.cpp.

  Add include <cstring> to util.cpp.

  Required to build with GCC (used on GCC architectures):
  undefined reference to std::__cxx11::basic_string

  PR:		237549
  Approved by:	pi (maintainer), tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D20050

Changes:
  head/textproc/htmltolatex/Makefile
  head/textproc/htmltolatex/files/patch-CH2L.cpp
  head/textproc/htmltolatex/files/patch-util.cpp
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2019-04-27 09:06:06 UTC 
Committed, thanks!