Bug 237607 - games/megaglest fails building with clang
Summary: games/megaglest fails building with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-27 16:09 UTC by Leon Dietrich
Modified: 2019-07-31 22:31 UTC (History)
1 user (show)

See Also:
monwarez: maintainer-feedback+


Attachments
The build log by poudriere (63.06 KB, text/plain)
2019-04-27 16:09 UTC, Leon Dietrich
no flags Details
Patch (1.22 KB, patch)
2019-04-30 17:07 UTC, Dmitry Marakasov
amdmi3: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leon Dietrich 2019-04-27 16:09:20 UTC
Created attachment 204067 [details]
The build log by poudriere

As of 3.13.0_7 megaglest uses clang as a compiler using poudriere by default. However clang isn't capable of building the port. Use GCC instead. Please review the attached build log for further details.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2019-04-30 16:58:38 UTC
The line you're referring to is just a warning.

Actual failure case is a typo in cmake options for VIEWER enabled (-BUILD_MEGAGLEST_MODEL_VIEWER=On should be -DBUILD_MEGAGLEST_MODEL_VIEWER=On).
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2019-04-30 17:07:48 UTC
Created attachment 204124 [details]
Patch
Comment 3 Thibault Payet 2019-05-01 07:19:16 UTC
Thanks for the patch, indeed it was a typo.

Using cmake bool help to prevent this. also nice catch for the ldflags uses.

The patch seems to be correct, I am currently launching a build to check that it build with all options enabled.
Comment 4 Thibault Payet 2019-05-01 12:39:33 UTC
Comment on attachment 204124 [details]
Patch

Tested it pass QA
Comment 5 Thibault Payet 2019-05-01 12:44:31 UTC
Comment on attachment 204124 [details]
Patch

I cannot set the maintainer-approval flags,

I approve this patch
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-05-13 21:47:31 UTC
A commit references this bug:

Author: amdmi3
Date: Mon May 13 21:46:33 UTC 2019
New revision: 501598
URL: https://svnweb.freebsd.org/changeset/ports/501598

Log:
  - Fix build with VIEWER enabled
  - Add missing USES
  - Switch to USES=localbase and opt_CMAKE_BOOL

  PR:		237607
  Reported by:	doralitze@chaotikum.org
  Approved by:	monwarez@mailoo.org (maintainer)

Changes:
  head/games/megaglest/Makefile
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-05-13 21:48:35 UTC
A commit references this bug:

Author: amdmi3
Date: Mon May 13 21:48:05 UTC 2019
New revision: 501599
URL: https://svnweb.freebsd.org/changeset/ports/501599

Log:
  MFH: r501598

  - Fix build with VIEWER enabled
  - Add missing USES
  - Switch to USES=localbase and opt_CMAKE_BOOL

  PR:		237607
  Reported by:	doralitze@chaotikum.org
  Approved by:	monwarez@mailoo.org (maintainer)
  Approved by:	ports-secteam (with hat)

Changes:
_U  branches/2019Q2/
  branches/2019Q2/games/megaglest/Makefile