Bug 237801 - multimedia/emby-server update to 4.1.1.0
Summary: multimedia/emby-server update to 4.1.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL: https://reviews.freebsd.org/D20334
Keywords: patch
Depends on:
Blocks: 236660
  Show dependency treegraph
 
Reported: 2019-05-08 20:09 UTC by Dries Michiels
Modified: 2019-06-01 06:05 UTC (History)
2 users (show)

See Also:
alucryd: maintainer-feedback+


Attachments
svn diff (78.33 KB, patch)
2019-05-08 20:09 UTC, Dries Michiels
no flags Details | Diff
svn diff (76.75 KB, patch)
2019-05-08 20:39 UTC, Dries Michiels
no flags Details | Diff
svn diff update to 4.1.1.0 (78.35 KB, patch)
2019-05-09 18:08 UTC, Dries Michiels
no flags Details | Diff
svn diff (78.35 KB, patch)
2019-05-09 18:09 UTC, Dries Michiels
no flags Details | Diff
svn diff (78.29 KB, patch)
2019-05-25 12:45 UTC, Dries Michiels
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels freebsd_committer freebsd_triage 2019-05-08 20:09:04 UTC
Created attachment 204277 [details]
svn diff

Changes to the port itself: 
 - Build the ffmpeg with gcc to streamline with the bundled ffdetect binary
 - Remove the update tarball from the rc script as we update through ports and don not want people getting mismatched checksums by updating this way
 - Streamline configure target: explicitly disable autodetected libraries that are unwanted
- Remove X11 requirement & gettext-runtime (not needed anymore)

Changelog for 4.1.1.0:
 - https://github.com/MediaBrowser/Emby.Releases/releases/tag/4.1.0.26
 - https://github.com/MediaBrowser/Emby.Releases/releases/tag/4.1.1.0
Comment 1 Dries Michiels freebsd_committer freebsd_triage 2019-05-08 20:10:54 UTC
QA checked:
portlint -ac
poudriere testport
Comment 2 Dries Michiels freebsd_committer freebsd_triage 2019-05-08 20:13:56 UTC
This patch should also fix the following bug (streamline configure target): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236660
Comment 3 Maxime Gauduin 2019-05-08 20:35:47 UTC
The updatepackage line is not actually for updating, but rather to check for potential updates and notify the user. The package can only be updated via this port indeed, but it's still nice to get notified when an updateis incoming.
Comment 4 Dries Michiels freebsd_committer freebsd_triage 2019-05-08 20:39:39 UTC
Created attachment 204278 [details]
svn diff
Comment 5 Dries Michiels freebsd_committer freebsd_triage 2019-05-08 20:41:04 UTC
I agree thats something we want to keep! However that feature is not working on my install :o! I'm running 4.0.2.0 and it say its up-to date. I'll send you a mail with a snip.
Comment 6 Dries Michiels freebsd_committer freebsd_triage 2019-05-09 18:08:50 UTC
Created attachment 204291 [details]
svn diff update to 4.1.1.0
Comment 7 Dries Michiels freebsd_committer freebsd_triage 2019-05-09 18:09:30 UTC
Created attachment 204292 [details]
svn diff

Marked other attachments obsolete.
Comment 8 Dries Michiels freebsd_committer freebsd_triage 2019-05-19 17:18:37 UTC
Can a committer please take a look at the patch? Thx!
Comment 9 Dries Michiels freebsd_committer freebsd_triage 2019-05-25 12:43:33 UTC
I just run time tested this today and it is better to remain using CLANG as compiler. GCC needs to define USE_GCC which also defines a run-time dependency. I don't think its a requirement to use GCC to build the ffmpeg.
Comment 10 Dries Michiels freebsd_committer freebsd_triage 2019-05-25 12:45:02 UTC
Created attachment 204603 [details]
svn diff

Revert using GCC; it is not a requirement to use it in the build. (it was broken in my previous patch as I did not have USE_GCC=yes which also results in run-time of GCC.
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2019-05-31 21:14:33 UTC
testbuilds@work
Comment 12 Kurt Jaeger freebsd_committer freebsd_triage 2019-06-01 06:05:28 UTC
Committed, thanks!
Comment 13 commit-hook freebsd_committer freebsd_triage 2019-06-01 06:05:53 UTC
A commit references this bug:

Author: pi
Date: Sat Jun  1 06:05:19 UTC 2019
New revision: 503217
URL: https://svnweb.freebsd.org/changeset/ports/503217

Log:
  multimedia/emby-server: upgrade 4.0.2.0 -> 4.1.1.0

  - Build the ffmpeg with gcc to streamline with the bundled ffdetect binary
  - Remove the update tarball from the rc script as we update through
    ports and don not want people getting mismatched checksums by
    updating this way
  - Streamline configure target: explicitly disable autodetected
    libraries that are unwanted
  - Remove X11 requirement & gettext-runtime (not needed anymore)

  PR:		237801
  Submitted by:	Dries Michiels <driesm.michiels@gmail.com>
  Approved by:	Maxime Gauduin <alucryd@archlinux.org> (maintainer)
  Relnotes: https://github.com/MediaBrowser/Emby.Releases/releases/tag/4.1.0.26
  	  https://github.com/MediaBrowser/Emby.Releases/releases/tag/4.1.1.0
  Differential Revision:	D20334

Changes:
  head/multimedia/emby-server/Makefile
  head/multimedia/emby-server/distinfo
  head/multimedia/emby-server/files/emby-server.in
  head/multimedia/emby-server/pkg-plist