Bug 237828 - www/py-django-allauth: Update to 0.39.1
Summary: www/py-django-allauth: Update to 0.39.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-10 12:03 UTC by vladimir.chukharev
Modified: 2019-05-12 21:23 UTC (History)
1 user (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2019-05-10 12:03 UTC, vladimir.chukharev 		vladimir.chukharev: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vladimir.chukharev 2019-05-10 12:03:30 UTC 
Created attachment 204308 [details]
Patch

Update www/py-django-allauth from 0.38.0 to 0.39.1.

There are backwards incompatible API changes in globus and linkedin_oauth2 providers, see https://django-allauth.readthedocs.io/en/latest/release-notes.html
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2019-05-12 13:13:13 UTC 
Hi Vladimir,

thank you for the patch. The build fails in the "stage QA" when using "poudriere -t":

> ====> Running Q/A tests (stage-qa)
> Error: www/py-django should not be depended upon. Instead, use one of the www/py-djangoXYZ port.
>*** Error code 1

This is due the fact that the use of the www/py-django metaport has been deprecated in ports r494913 .

Do you need the port for another version of Django beside 1.11? Otherwise I would commit your patch with www/django111 instead of www/django in the RUN_DEPENDS.
Comment 2 vladimir.chukharev 2019-05-12 15:21:07 UTC 
(In reply to Kai Knoblich from comment #1)
Hi Kai,

Thanks for catching it. I did test with poudriere, but with ports tree before the deprecation was commited. Yesterday I updated the tree, and now I see the error.

www/py-django111 refused to build with python3.6 for me for some reason, and that's why I change the RUN_DEPENDS value.

It seems, the dependence should take into account the Python version, since www/py-django22 ignores @py27 and builds for py36.
Comment 3 vladimir.chukharev 2019-05-12 15:36:39 UTC 
Kai,

I found out that www/py-django111 failed for @py36 flavor because I wanted support for mysql. Without that option, it builds alright.

I think, it's OK to commit with www/py-django111 as you suggested. Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-05-12 21:22:06 UTC 
A commit references this bug:

Author: kai
Date: Sun May 12 21:21:39 UTC 2019
New revision: 501508
URL: https://svnweb.freebsd.org/changeset/ports/501508

Log:
  www/py-django-allauth: Update to 0.39.1

  * Pet portlint

  Changelog since 0.38.0:

  * The linkedin_oauth2 provider now gracefully deals with old V1 data that
    might still be present in SocialAccount.extra_data.
  * New providers: JupyterHub (OAuth2), Steam (OpenID)
  * Refactor translations: Portuguese (Portugal).
  * Add testing for Django 2.2 (no code changes required)

  Backwards incompatible changes

  * linkedin_oauth2: As the LinkedIn V1 API is deprecated, the user info
    endpoint has been moved over to use the API V2. The format of the user
    extra_data is different and the profile picture is absent by default.

  https://github.com/pennersr/django-allauth/blob/0.39.1/ChangeLog.rst

  PR:		237828
  Submitted by:	vladimir.chukharev@gmail.com (maintainer)

Changes:
  head/www/py-django-allauth/Makefile
  head/www/py-django-allauth/distinfo
Comment 5 Kai Knoblich freebsd_committer freebsd_triage 2019-05-12 21:23:00 UTC 
Committed, thank you for your info and the patch!