Bug 238105 - sysutils/google-compute-engine-oslogin: patches to fix linux-isms
Summary: sysutils/google-compute-engine-oslogin: patches to fix linux-isms
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-24 14:58 UTC by jay
Modified: 2019-05-27 20:25 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (lucas.kanashiro)


Attachments
Patch to correct 3 bugs in google-oslogin-control (2.58 KB, patch)
2019-05-24 14:58 UTC, jay
no flags Details | Diff
Patch to update to version 1.5.3 (1.50 KB, patch)
2019-05-27 16:55 UTC, Lucas Kanashiro
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jay 2019-05-24 14:58:54 UTC
Created attachment 204594 [details]
Patch to correct 3 bugs in google-oslogin-control

This application has three Linux'isms that cause it not to work on FreeBSD.

* The sudoers file is hard-coded to /etc/sudoers.d/google-oslogin
* /bin/echo -e is used
* The grep command to determine if a service is not installed always errs out

My fixes have been accepted by the upstream project in the development branch:

https://github.com/GoogleCloudPlatform/compute-image-packages/pull/778/files
https://github.com/GoogleCloudPlatform/compute-image-packages/pull/781/files

Unfortunately, since the project has just made a release, I've been informed that "It might take some time for [these] changes to make it into master."

The diff is against the current version in HEAD which is tag 20190416.
Comment 1 Lucas Kanashiro 2019-05-27 12:31:14 UTC
(In reply to jay from comment #0)
Thanks for submitting those patches upstream. Fortunately, they already made a new release containing your patches [1]. I'll update the package for this latest release ASAP.

[1] https://github.com/GoogleCloudPlatform/compute-image-packages/releases/tag/20190522
Comment 2 Lucas Kanashiro 2019-05-27 16:55:21 UTC
Created attachment 204653 [details]
Patch to update to version 1.5.3

Attached is a patch to update google-compute-engine-oslogin to version 1.5.3 which contains the patch set reported in this bug.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-05-27 20:24:37 UTC
A commit references this bug:

Author: swills
Date: Mon May 27 20:24:00 UTC 2019
New revision: 502827
URL: https://svnweb.freebsd.org/changeset/ports/502827

Log:
  sysutils/google-compute-engine-oslogin: update to 1.5.3

  Fixes linux-isms

  PR:		238105
  Submitted by:	Lucas Kanashiro <lucas.kanashiro@collabora.com> (maintainer)
  Reported by:	jay@meangrape.com

Changes:
  head/sysutils/google-compute-engine-oslogin/Makefile
  head/sysutils/google-compute-engine-oslogin/distinfo
Comment 4 Steve Wills freebsd_committer freebsd_triage 2019-05-27 20:25:46 UTC
Committed, thanks!