Created attachment 204754 [details] Update emulators/ucon64 to 2.2.0 - Update to uCON64 2.2.0 - Add LICENSE (GPLv2 http://ucon64.sourceforge.net/ucon64/license.html) - Minor Makefile edits to make portlint happy - Remove obsolete port patches that are now upstreamed and update libdiscmage patch. Patch and poudriere testport log are attached.
Created attachment 204755 [details] uCON64 2.2.0 poudriere testport log
[okeeblow@curus#okeeblow] ucon64 --version uCON64 2.2.0 UNIX (FreeBSD) 1999-2019 Uses code from various people. See 'developers.html' for more! This may be freely redistributed under the terms of the GNU Public License version: 2.2.0 (Jun 1 2019) platform: UNIX (FreeBSD) endianess: little debug: no parallel port backup unit support: yes USB port backup unit support: no ANSI colors enabled: yes gzip and zip support: yes, zlib 1.2.11 configuration file (present): /usr/home/okeeblow/.ucon64rc discmage DLL: /usr/local/lib/libdiscmage.so discmage enabled: yes, 0.0.7 (supported: BIN, ISO, CDI) configuration directory: /home/okeeblow/.ucon64/ DAT file directory: /home/okeeblow/.ucon64/dat/ entries in DATabase: 0 DATabase enabled: no
Created attachment 204758 [details] Update emulators/ucon64 to 2.2.0 and add OPTIONS Improved patch: - Fix inadvertent explicit default PREFIX use - Add OPTIONS to control all default configure settings including color support, parallel support, zlib usage, and if libdiscmage should be built and installed. - Add USB support using built-in libusb and enable it by default since there is no extra dependency. - Use a real pkg-plist instead of PLIST_FILES and enable %%DISCMAGE%% sub since libdiscmage.so is now optional. Tested building with and without all options, but especially DISCMAGE.
Created attachment 204759 [details] uCON64 2.2.0 poudriere testport log
@Allison Great detail on the patch changeset, much easier to review. Note: For future reference, attaching poudriere logs is not required unless requested for specific reasons. Feel free to just confirm QA as follows: portlint: OK (looks fine.) testport: OK (poudriere: <versions>, <archs>, <OPTIONS> tested) maketest: OK (if applicable)
Thanks for the heads-up. I remember it being asked of me on every port bug a few years ago, and I use it anyway to build my packages so I just got in the habit :)
A commit references this bug: Author: kai Date: Sat Jun 8 16:16:49 UTC 2019 New revision: 503742 URL: https://svnweb.freebsd.org/changeset/ports/503742 Log: emulators/ucon64: Update to 2.2.0 * Switch to options framework to make the port more flexible * Remove no longer required patches that have been adapted by upstream * Add license information Also while I'm here: * Order variables a bit according to the PHB with the support of portclippy. Notable changes since 2.0.0: Additions: * (N64) Support for remaining 6101, 6103, and 6106 bootcodes * (Coleco) Recognition of Coleco ROMs * (Virtual Boy) Recognition of Virtual Boy ROMs * (NDS) Recognition of DS ROMs * (Atari) Recognition of Atari VCS 2600 ROMs * Added support for NetBSD * Introduction of many new command-line switches Updates/Fixes: * Updated support for OpenBSD (64-bit) * Many fixes/improvements for backup devices, ROM types and command-line switches http://ucon64.sourceforge.net/ucon64/changes.html PR: 238275 Submitted by: Allison Nicole Reid <root@cooltrainer.org> (maintainer) Changes: head/emulators/ucon64/Makefile head/emulators/ucon64/distinfo head/emulators/ucon64/files/patch-Makefile.in head/emulators/ucon64/files/patch-backup-lynxit.c head/emulators/ucon64/files/patch-libdiscimage-misc_z.c head/emulators/ucon64/files/patch-libdiscimage-unzip.h head/emulators/ucon64/files/patch-misc-archive.c head/emulators/ucon64/files/patch-misc-unzip.h head/emulators/ucon64/files/patch-ucon64.c head/emulators/ucon64/files/patch-ucon64__misc.c head/emulators/ucon64/files/patch-ucon64_misc.c
Committed, thank you for the patch! I did some small modifications (sorted variables a bit more, optimized the usage of the options framework and fixed a hardcoded reference of '/usr/local' in files/patch-ucon64__misc.c .