Bug 238290 - net-im/coyim: Fix missing version number in "About" dialog
Summary: net-im/coyim: Fix missing version number in "About" dialog
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Steve Wills
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2019-06-02 14:09 UTC by Santhosh Raju
Modified: 2019-06-08 00:52 UTC (History)
0 users

See Also:
koobs: merge-quarterly?


Attachments
Fixes the version number displayed in the "About" dialog box. (754 bytes, patch)
2019-06-02 14:09 UTC, Santhosh Raju
santhosh.raju: maintainer-approval+
Details | Diff
Fixes the version number displayed in the "About" dialog box (Now uses shebangfix). (1005 bytes, patch)
2019-06-02 15:45 UTC, Santhosh Raju
santhosh.raju: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Santhosh Raju 2019-06-02 14:09:11 UTC
Created attachment 204781 [details]
Fixes the version number displayed in the "About" dialog box.

The "About" dialog does not display the version number because of a missing version number file which was not generated during the build. 

This patch addresses this issue and now generates the above mentioned version file before starting the build.

It would be nice if the patch can be applied to the ports tree of FreeBSD.

Regards
Santhosh
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-06-02 14:53:06 UTC
Thank you for the patch Santhosh

You should be able to use USES=shebangfix instead of the custom post-patch target to fix the bash shebang. Worth giving it a go
Comment 2 Santhosh Raju 2019-06-02 14:57:59 UTC
(In reply to Kubilay Kocak from comment #1)

Oh I did not know about this, thanks for letting me know. Let me make the change and test it out.

Will post the updated patch once I make the changes and test it out successfully.
Comment 3 Santhosh Raju 2019-06-02 15:45:48 UTC
Created attachment 204784 [details]
Fixes the version number displayed in the "About" dialog box (Now uses shebangfix).

(In reply to Kubilay Kocak from comment #1)

I have made the changes and now it uses the "shebangfix" instead of doing a custom post-patch search and replace.

The new patch attached address this issue and I can confirm the builds are working as expected.

Let me know if the patch looks good to be applied.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-06-08 00:52:33 UTC
A commit references this bug:

Author: swills
Date: Sat Jun  8 00:51:36 UTC 2019
New revision: 503688
URL: https://svnweb.freebsd.org/changeset/ports/503688

Log:
  net-im/coyim: Fix missing version number in About dialog

  PR:		238290
  Submitted by:	Santhosh Raju <santhosh.raju@gmail.com> (maintainer)

Changes:
  head/net-im/coyim/Makefile
Comment 5 Steve Wills freebsd_committer freebsd_triage 2019-06-08 00:52:41 UTC
Committed, thanks!