Bug 238348 - x11/xfce4-screensaver: Fix inhibit lock
Summary: x11/xfce4-screensaver: Fix inhibit lock
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-05 18:48 UTC by Olivier Duchateau
Modified: 2019-06-06 22:07 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+


Attachments
Fix inhibit lock (7.15 KB, patch)
2019-06-05 18:48 UTC, Olivier Duchateau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2019-06-05 18:48:51 UTC
Created attachment 204847 [details]
Fix inhibit lock

This patch fixes inhibit (and uninhibit) locks, because by default it uses the org.gnome.ScreenSaver service (not available on Xfce session).

This patch [1] was approved (and merged) by upstream.

Moreover improve Makefile (USES= gl and add sysutils/consolekit2 as dependency).

[1] https://bugzilla.xfce.org/show_bug.cgi?id=15551
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2019-06-05 19:49:46 UTC
Thanks!

I'm going to test and commit this.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-06-06 17:16:46 UTC
A commit references this bug:

Author: madpilot
Date: Thu Jun  6 17:16:33 UTC 2019
New revision: 503583
URL: https://svnweb.freebsd.org/changeset/ports/503583

Log:
  Import upstreamed patch to fix the Inhibit lock functionality.

  Also add some required dependencies.

  PR:		238348
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>
  MFH:		2019Q2

Changes:
  head/x11/xfce4-screensaver/Makefile
  head/x11/xfce4-screensaver/files/patch-src_gs-listener-dbus.c
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2019-06-06 17:19:15 UTC
Committed.

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-06-06 22:07:48 UTC
A commit references this bug:

Author: madpilot
Date: Thu Jun  6 22:07:17 UTC 2019
New revision: 503607
URL: https://svnweb.freebsd.org/changeset/ports/503607

Log:
  MFH: r503583

  Import upstreamed patch to fix the Inhibit lock functionality.

  Also add some required dependencies.

  PR:		238348
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>

  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2019Q2/
  branches/2019Q2/x11/xfce4-screensaver/Makefile
  branches/2019Q2/x11/xfce4-screensaver/files/patch-src_gs-listener-dbus.c