Bug 238691 - math/diehard: depends on to-be-removed gets(3)
Summary: math/diehard: depends on to-be-removed gets(3)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks: 222796
  Show dependency tree / graph
 
Reported: 2019-06-18 14:50 UTC by Ed Maste
Modified: 2019-09-01 17:30 UTC (History)
2 users (show)

See Also:

Attachments
svn-diff-diehard (13.74 KB, patch)
2019-08-03 11:24 UTC, Walter Schwarzenfeld 		no flags Details | Diff
svn-diff-diehard_v2 (14.26 KB, patch)
2019-09-01 17:21 UTC, Walter Schwarzenfeld 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2019-06-18 14:50:09 UTC 
I intend to remove gets(3) in the near future and this port failed in the exp-run (PR 222796)

http://package18.nyi.freebsd.org/data/112amd64PR222796-default/2018-10-27_20h58m08s/logs/errors/diehard-0.1.log

diehard.o: In function `diehard':
diehard.c:(.text+0x6f7): undefined reference to `gets'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error code 1
Comment 1 Walter Schwarzenfeld freebsd_triage 2019-08-03 11:24:21 UTC 
Created attachment 206233 [details]
svn-diff-diehard
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2019-09-01 16:50:38 UTC 
This patch does(In reply to Walter Schwarzenfeld from comment #1)
This patch doesn't seem removing use of gets(3) completely?
Comment 3 Walter Schwarzenfeld freebsd_triage 2019-09-01 17:21:27 UTC 
Created attachment 207071 [details]
svn-diff-diehard_v2
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-09-01 17:28:40 UTC 
A commit references this bug:

Author: lwhsu
Date: Sun Sep  1 17:28:02 UTC 2019
New revision: 510710
URL: https://svnweb.freebsd.org/changeset/ports/510710

Log:
  Add a patch to remove use of gets(3)

  PR:		238691
  Submitted by:	Walter Schwarzenfeld <w.schwarzenfeld at utanet.at>
  Reported by:	emaste
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/math/diehard/Makefile
  head/math/diehard/files/patch-cdbday.c
  head/math/diehard/files/patch-cdbinrnk.c
  head/math/diehard/files/patch-cdbitst.c
  head/math/diehard/files/patch-cdomso.c
  head/math/diehard/files/patch-cdoperm5.c
  head/math/diehard/files/patch-cdosum.c
  head/math/diehard/files/patch-cdpark.c
  head/math/diehard/files/patch-cnt1s
  head/math/diehard/files/patch-craptest.c
  head/math/diehard/files/patch-d3sphere.c
  head/math/diehard/files/patch-diehard.c