Bug 238775 - sysutils/arcconf: Update to 3.01.23531
Summary: sysutils/arcconf: Update to 3.01.23531
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-06-23 09:04 UTC by thomas
Modified: 2020-01-06 22:26 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (michael)


Attachments
arcconf Makefile and distinfo diff in one file (1.92 KB, patch)
2019-06-23 09:04 UTC, thomas
no flags Details | Diff
Updated diff (1.75 KB, patch)
2019-07-23 18:21 UTC, thomas
no flags Details | Diff
Force to use gcc48+ (490 bytes, patch)
2020-01-05 05:57 UTC, thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description thomas 2019-06-23 09:04:47 UTC
Created attachment 205293 [details]
arcconf Makefile and distinfo diff in one file

* Update arcconf to 3_01_23531
* Update distinfo
* Add run dependecy to GCC (port default) because arcconf needs libstdc++.so.6: version GLIBCXX_3.4.11 (port misc/compat9x latest support is  GLIBCXX_3.4.9)
* Remove OS check

Patch attached
Comment 1 michael 2019-06-23 18:10:02 UTC
OK, since 10.x is EOL, we assume it is >= 11.X. Looks fine, please commit
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2019-07-23 06:55:52 UTC
Cannot apply the patch. Could you submit it again?

% curl -s -L 'https://bz-attachments.freebsd.org/attachment.cgi?id=205293' | patch
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|diff -u arcconf.orig/Makefile arcconf/Makefile
|--- arcconf.orig/Makefile       2019-04-07 06:04:44.000000000 +0000
|+++ arcconf/Makefile    2019-06-23 09:29:07.164130000 +0000
--------------------------
Patching file Makefile using Plan A...
patch: **** malformed patch at line 6:
Comment 3 thomas 2019-07-23 18:21:07 UTC
Created attachment 206016 [details]
Updated diff

Updated diff. "cat arcconf.diff | patch" applied cleanly
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2019-07-25 01:48:26 UTC
BTW, never decrement PORTEPOCH or reset to zero. See porter's handbook 5.2.3.2.

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-07-25 02:04:02 UTC
A commit references this bug:

Author: meta
Date: Thu Jul 25 02:03:17 UTC 2019
New revision: 507307
URL: https://svnweb.freebsd.org/changeset/ports/507307

Log:
  sysutils/arcconf: Update to 3.01.23531

  * Add run dependecy to GCC (port default) because arcconf needs
    libstdc++.so.6: version GLIBCXX_3.4.11
    (port misc/compat9x latest support is  GLIBCXX_3.4.9)
  * Remove os check since 10.x is EoL

  PR:		238775
  Submitted by:	thomas@bsdunix.ch
  Approved by:	maintainer

Changes:
  head/sysutils/arcconf/Makefile
  head/sysutils/arcconf/distinfo
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2019-07-25 02:06:53 UTC
Committed with a minor change, thanks!
Comment 7 igor.polovykh 2020-01-03 22:35:03 UTC
arcconf is not work. even 3_01_23531 version.

[ root@ /usr/ports/sysutils/arcconf ] # uname -a
FreeBSD video.bvgm.org 12.1-RELEASE-p1 FreeBSD 12.1-RELEASE-p1 8d3f226f4b8(releng/12.1) BVG  amd64

[ root@ /usr/ports/sysutils/arcconf ] # head Makefile
# Created by: michael@fuckner.net
# $FreeBSD$

PORTNAME=       arcconf
DISTVERSION=    3_01_23531
PORTREVISION=   1
PORTEPOCH=      1
CATEGORIES=     sysutils
MASTER_SITES=   http://download.adaptec.com/raid/storage_manager/
DISTNAME=       arcconf_v${DISTVERSION}

[ root@ /usr/ports/sysutils/arcconf ] # arcconf
ld-elf.so.1: /usr/lib/libstdc++.so.6: version GLIBCXX_3.4.11 required by /usr/local/sbin/arcconf not found

[ root@ /usr/ports/sysutils/arcconf ] #
Comment 8 thomas 2020-01-05 04:56:25 UTC
You need at least gcc9 version installed to make it run. 
The arcconf Makefile contains: 
LIB_DEPENDS=    libstdc++.so.6:lang/gcc${GCC_DEFAULT}

Did you set a specific gcc version in /etc/make.conf?
Comment 9 thomas 2020-01-05 05:57:58 UTC
Created attachment 210459 [details]
Force to use gcc48+
Comment 10 thomas 2020-01-05 05:58:46 UTC
(In reply to igor.polovykh from comment #7)
Could you try the attached patch? It add USE_GCC= 4.8+ to the Makefile.
Comment 11 igor.polovykh 2020-01-05 08:14:04 UTC
after installation gcc 9.2 arcconf works good.

workaround:
remove /usr/lib/libstdc++.so.6
and use /usr/local/lib/compat/pkg/libstdc++.so.6.0.19 instead because gcc does not need at all in bsd
It contains necessary code.
Comment 12 thomas 2020-01-06 22:26:54 UTC
(In reply to igor.polovykh from comment #11)
Great. I submitted a PR with a fix that should make it more robust against older libstdc++.so.6 from old bsd versions or compatXX ports.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243142