Bug 238930 - databases/pgmetrics: Switch to USES=go:modules, fix build with go1.13beta1
Summary: databases/pgmetrics: Switch to USES=go:modules, fix build with go1.13beta1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-01 18:08 UTC by Dmitri Goutnik
Modified: 2019-07-26 07:31 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback-

Attachments
patch file (2.07 KB, patch)
2019-07-01 18:08 UTC, Dmitri Goutnik 		dmgk: maintainer-approval? (girgen)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-07-01 18:08:19 UTC 
Created attachment 205473 [details]
patch file

===>  Building for pgmetrics-1.7.0
$GOPATH/go.mod exists but should not
*** Error code 1

- Switch to USES=go:modules, this also fixes the build with go1.13beta1
- Remove unneeded targets

QA:
  poudriere testport: OK (120a-go1.12.6, 120a-go1.13beta1)
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-07-26 07:31:07 UTC 
A commit references this bug:

Author: tobik
Date: Fri Jul 26 07:30:33 UTC 2019
New revision: 507342
URL: https://svnweb.freebsd.org/changeset/ports/507342

Log:
  databases/pgmetrics: Switch to USES=go:modules

  - Remove unneeded targets
  - Drop nop BUILD_AS_NON_ROOT while here
  - Fix build with go1.13beta1

  ===>  Building for pgmetrics-1.7.0
  $GOPATH/go.mod exists but should not
  *** Error code 1

  PR:		238930
  Submitted by:	Dmitri Goutnik <dg@syrec.org>
  Approved by:	girgen (maintainer timeout, 24 days)

Changes:
  head/databases/pgmetrics/Makefile