Bug 239084 - databases/db5 use ssl master_sites
Summary: databases/db5 use ssl master_sites
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-09 19:57 UTC by Miyashita Touka
Modified: 2019-07-09 21:45 UTC (History)
0 users

See Also:
mandree: maintainer-feedback+

Attachments
patch (499 bytes, patch)
2019-07-09 19:57 UTC, Miyashita Touka 		mandree: maintainer-approval-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miyashita Touka 2019-07-09 19:57:10 UTC 
Created attachment 205621 [details]
patch

Add HTTPS link to MASTER_SITES
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2019-07-09 21:39:41 UTC 
Please add a few words of discussion or motivation why we should do this. 

We have checksums, but that argument goes either way, either (a) we don't need HTTPS, or - opposite argument - (b) if we add untrusted sites, we'll still trust the tarball if the checksum matches.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-07-09 21:45:13 UTC 
A commit references this bug:

Author: mandree
Date: Tue Jul  9 21:44:31 UTC 2019
New revision: 506319
URL: https://svnweb.freebsd.org/changeset/ports/506319

Log:
  Switch db5/db6 to download from Oracle's https:// sites.

  The http:// sites issue 301-type redirects to https:// so we can spare
  everyone the roundtrip.

  Inspired by...
  PR:		239084
  Submitted by:	Miyashita Touka

Changes:
  head/databases/db5/Makefile
  head/databases/db6/Makefile
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2019-07-09 21:45:29 UTC 
Comment on attachment 205621 [details]
patch

In fact, Oracle offer the files by https:// as well and redirects from http:// to https://. I have committed a change tracking that, so this one isn't needed.