Bug 239157 - lang/ocaml: fix build on armv7
Summary: lang/ocaml: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-12 11:16 UTC by Piotr Kubaj
Modified: 2019-08-01 19:31 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (michipili)

Attachments
patch (3.05 KB, patch)
2019-07-12 11:16 UTC, Piotr Kubaj 		no flags Details | Diff
v2 (3.40 KB, patch)
2019-07-12 11:19 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (michipili)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-07-12 11:16:43 UTC 
Created attachment 205711 [details]
patch

armv7 requires -Wl,-znotext in LDFLAGS (same as i386), added definition for triple target and include term.h in the test for tgetent.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2019-07-12 11:19:35 UTC 
Created attachment 205712 [details]
v2

Spacetime profiling is unavailable on armv7 as well.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-08-01 19:31:13 UTC 
A commit references this bug:

Author: pkubaj
Date: Thu Aug  1 19:30:39 UTC 2019
New revision: 507827
URL: https://svnweb.freebsd.org/changeset/ports/507827

Log:
  lang/ocaml: fix build on armv7

  armv7 requires -Wl,-znotext in LDFLAGS (same as i386), added definition for triple target and include term.h in the test for tgetent.

  PR:		239157
  Approved by:	michipili@gmail.com (maintainer timeout), tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D21085

Changes:
  head/lang/ocaml/Makefile
  head/lang/ocaml/files/patch-configure