Created attachment 206085 [details] slice readahead patch Add additional (default disabled) patch to enable slice read ahead with the slice filter.
Hey, Ryan, thanks for the patch. Could you briefly explain what the module does exactly? For people who google, for example, who need something like that. Thanks a lot :-)
The existing slice module (https://nginx.org/en/docs/http/ngx_http_slice_module.html) only starts fetching a given slice whenever bytes in that range for that slice is requested. The patch allows you to configure a variable (slice_read_ahead X) which will cause nginx to start proactively reading X future slices. This allows the node to start filling the cache ahead of the user to keep traffic less bursty as well as improve performance.
Er, to clarify: this patch allows you to control how many slices are read ahead of time. By default, slice will read them all as fast as they can. Even if a user just asked for bytes in the first slice and stopped their download.
Heya Ryan, I don't see a description for the module in "make config" right now. Can you confirm that? [x] STREAM_SSL_PREREAD Enable stream_ssl_preread module (SSL req.) [x] HTTP_SLICE_AHEAD [ ] AJP 3rd party ajp module This is included in the patch: HTTP_SLICE_DESC= Enable http_slice module HTTP_SLICE_AHEAD= Enable slice read ahead patch HTTP_SSL_DESC= Enable http_ssl module it is missing the "Enable slice read ahead patch"
Sorry, typo on my part: HTTP_SLICE_AHEAD= should be HTTP_SLICE_AHEAD_DESC= I can generate a new patch if required, just let me know.
From which source should the module be downloaded?
It's included in the diff as a patch.
i dont find infos for a download into the diff
It is not a separate download. It is a patch that is included in the diff that is optionally applied whenever the option is enabled: =================================================================== --- files/extra-patch-src_http_modules_ngx__http__slice_read_ahead.c (nonexistent) +++ files/extra-patch-src_http_modules_ngx__http__slice_read_ahead.c (revision 507359) @@ -0,0 +1,456 @@ +--- src/http/modules/ngx_http_slice_filter_module.c.orig 2019-04-23 13:12:58 UTC ++++ src/http/modules/ngx_http_slice_filter_module.c +@@ -2,6 +2,10 @@ + /* + * Copyright (C) Roman Arutyunyan + * Copyright (C) Nginx, Inc. ++ * Copyright (C) Carey Gister ++ * Copyright (C) Metapeer, Inc. ++ * ++ * Retrieve slices with an optional look-a-head of N slices where N is a float value. + */
A commit references this bug: Author: joneum Date: Tue Aug 6 08:46:37 UTC 2019 New revision: 508238 URL: https://svnweb.freebsd.org/changeset/ports/508238 Log: - Add https to MASTER_SITES - Add third-party slice read ahead patch PR: 239464 239083 Sponsored by: Netzkommune GmbH Changes: head/www/nginx/Makefile head/www/nginx/Makefile.extmod head/www/nginx/Makefile.options.desc head/www/nginx/files/extra-patch-src_http_modules_ngx__http__slice_read_ahead.c