Bug 239661 - x11-wm/fvwm: Add DEPRECATED, EXPIRATION_DATE: Unsupported upstream
Summary: x11-wm/fvwm: Add DEPRECATED, EXPIRATION_DATE: Unsupported upstream
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-05 16:16 UTC by Walter Schwarzenfeld
Modified: 2019-09-04 08:12 UTC (History)
4 users (show)

See Also:


Attachments
svn-diff-fvwm (303 bytes, patch)
2019-08-06 17:04 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-fvwm-new (1.05 KB, patch)
2019-08-26 23:45 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-fvwm-new_v2 (1.26 KB, patch)
2019-08-27 00:17 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-fvwm-new_v3 (1.24 KB, patch)
2019-08-27 00:28 UTC, Walter Schwarzenfeld
koobs: maintainer-approval-
Details | Diff
svn-diff-fvwm-new_v3 (1.24 KB, patch)
2019-08-27 00:28 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-fvwm-new_v4 (1.21 KB, patch)
2019-08-27 07:48 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld freebsd_triage 2019-08-05 16:16:20 UTC
fvwm is no more supported.

http://fvwm.sourceforge.net/download/

-->
Obsolete packages:

    Older 2.x.x versions: here (Note! Versions prior to 2.4.0 are no longer supported.)
    Last 1.xx Version: 1.24r (Note! This version is no longer supported.)
    Very old 1.x releases: here
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2019-08-06 16:04:53 UTC
Do you have a patch for this to set as stated in bug?
Comment 2 Walter Schwarzenfeld freebsd_triage 2019-08-06 17:04:30 UTC
Created attachment 206309 [details]
svn-diff-fvwm

Ups... forgot the patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-08-06 17:25:48 UTC
A commit references this bug:

Author: jgh
Date: Tue Aug  6 17:25:34 UTC 2019
New revision: 508263
URL: https://svnweb.freebsd.org/changeset/ports/508263

Log:
  - set deprecation
  - set expiration to 2019-10-05

  PR:		239661
  Submitted by:	w.schwarzenfeld@utanet.at (based on)

Changes:
  head/x11-wm/fvwm/Makefile
Comment 4 Jason Helfman freebsd_committer freebsd_triage 2019-08-06 17:27:00 UTC
Thanks for your contribution! I adjusted expiration date, as this seemed too generous for an unsupported upstream version that is unfetchable.

Thanks, again!
-jgh
Comment 5 Walter Schwarzenfeld freebsd_triage 2019-08-06 17:28:40 UTC
Okay!
Comment 6 Bjoern A. Zeeb freebsd_committer freebsd_triage 2019-08-26 22:50:16 UTC
The source code is now online again on
https://github.com/fvwmorg/fvwm1

Can the port please not be deprecated?
Comment 7 Walter Schwarzenfeld freebsd_triage 2019-08-26 22:58:30 UTC
Can you provide a patch with new MASTER_SITE?
Comment 8 Walter Schwarzenfeld freebsd_triage 2019-08-26 23:45:25 UTC
Created attachment 206938 [details]
svn-diff-fvwm-new

Please test the patch, I cannot test it I have fvwm-crystal installed (this conflicts).
Comment 9 Walter Schwarzenfeld freebsd_triage 2019-08-27 00:02:45 UTC
Comment on attachment 206938 [details]
svn-diff-fvwm-new

No, was wrong.
Comment 10 Walter Schwarzenfeld freebsd_triage 2019-08-27 00:17:13 UTC
Created attachment 206939 [details]
svn-diff-fvwm-new_v2

This should work.
Comment 11 Walter Schwarzenfeld freebsd_triage 2019-08-27 00:28:01 UTC
Created attachment 206940 [details]
svn-diff-fvwm-new_v3

Forgot I have commented out conflicts.
Comment 12 Walter Schwarzenfeld freebsd_triage 2019-08-27 00:28:49 UTC
Created attachment 206943 [details]
svn-diff-fvwm-new_v3

Forgot I have commented out conflicts.
Comment 13 Mathieu Arnold freebsd_committer freebsd_triage 2019-08-27 06:45:46 UTC
Please use USE_GITHUB.
Comment 14 Walter Schwarzenfeld freebsd_triage 2019-08-27 07:00:57 UTC
Syntax?
Comment 15 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-27 07:25:31 UTC
Comment on attachment 206940 [details]
svn-diff-fvwm-new_v3

Patch needs updating to USE_GITHUB [1] and not use a moving branch target (master)

[1] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-master_sites-github-description
Comment 16 Walter Schwarzenfeld freebsd_triage 2019-08-27 07:48:45 UTC
Created attachment 206950 [details]
svn-diff-fvwm-new_v4

Found it.
Comment 17 Bjoern A. Zeeb freebsd_committer freebsd_triage 2019-08-27 14:55:07 UTC
Comment on attachment 206950 [details]
svn-diff-fvwm-new_v4

I can confirm that the port builds, installs, and default fvwm starts.
I can do more sophisticated tests if needed once the rest of the notebook is all a bit more working as well :-)
Comment 18 Jason Helfman freebsd_committer freebsd_triage 2019-08-27 19:31:56 UTC
The updated patch to bring the software back will not be committed to the tree.  This is a unmaintained project.
Comment 19 Bjoern A. Zeeb freebsd_committer freebsd_triage 2019-08-27 19:42:22 UTC
(In reply to Jason Helfman from comment #18)

What needs to be done to keep it alive?  Just because development has stopped (and by that argument a loooong time ago) doesn't mean people are not using it anymore.

I can keep a private copy of the port, but if two people do that we are already wasting resources.
Comment 20 Jason Helfman freebsd_committer freebsd_triage 2019-08-27 19:56:22 UTC
(In reply to Bjoern A. Zeeb from comment #19)

Please reach out to portmgr@ regarding this issue. I am fine in working through whatever the solution is to have it resolved, but at this point portmgr@ has agreed that adding this to the tree is not an option in this state.
Comment 21 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-04 08:12:15 UTC
^Triage: Correct resolution (FIXED, per original report)

@Bjoern If you'd like to make a case for the ports resurrection, please:

- Open a new issue: Assignee: portmgr
- With the patch attached here included
- With this issue ID in See Also: