Bug 240195 - net/libdmapsharing: Explicitly disable the dependency on devel/check
Summary: net/libdmapsharing: Explicitly disable the dependency on devel/check
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-29 17:56 UTC by Ting-Wei Lan
Modified: 2019-08-30 11:11 UTC (History)
1 user (show)

See Also:


Attachments
Pass --disable-check to the configure script (468 bytes, patch)
2019-08-29 17:56 UTC, Ting-Wei Lan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2019-08-29 17:56:14 UTC
Created attachment 207005 [details]
Pass --disable-check to the configure script

By default, the configure script of net/libdmapsharing detects devel/check automatically. If devel/check is installed, net/libdmapsharing will link to it. It can cause problems because devel/check isn't declared as a dependency of net/libdmapsharing, so libdmapsharing-3.0.so will be broken if devel/check is removed.

$ ldd /usr/local/lib/libdmapsharing-3.0.so
...
        libcheck.so.0 => not found (0)
...

Since devel/check is just a unit test framework, it should be safe to disable it unconditionally.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-08-30 11:11:20 UTC
A commit references this bug:

Author: tobik
Date: Fri Aug 30 11:10:55 UTC 2019
New revision: 510260
URL: https://svnweb.freebsd.org/changeset/ports/510260

Log:
  net/libdmapsharing: Explicitly disable the dependency on devel/check

  By default, the configure script of net/libdmapsharing detects
  devel/check automatically.  If devel/check is installed,
  net/libdmapsharing will link to it.  It can cause problems because
  devel/check is not declared as a dependency of net/libdmapsharing,
  so libdmapsharing-3.0.so will be broken if devel/check is removed.

  $ ldd /usr/local/lib/libdmapsharing-3.0.so
  ...
  libcheck.so.0 => not found (0)
  ...

  Since devel/check is just a unit test framework, it should be safe
  to disable it unconditionally.

  PR:		240195
  Submitted by:	Ting-Wei Lan <lantw44@gmail.com>

Changes:
  head/net/libdmapsharing/Makefile