Bug 240210 - x11-fm/konqueror: optionally depends on www/tidy-lib
Summary: x11-fm/konqueror: optionally depends on www/tidy-lib
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-30 13:54 UTC by Ting-Wei Lan
Modified: 2019-08-30 20:06 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2019-08-30 13:54:59 UTC 
If www/tidy-lib is installed on the system, the build system of x11-fm/konqueror will automatically pick it up as an optional dependency. Since www/tidy-lib isn't declared as a dependency of x11-fm/konqueror in the port, pkg allows the user to delete www/tidy-lib after x11-fm/konqueror is installed. Therefore, it is possible break konqueror even if pkg is used normally.

$ ldd /usr/local/lib/qt5/plugins/validatorsplugin.so
...
        libtidy-0.99.so.0 => not found (0)
...
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2019-08-30 19:43:07 UTC 
Moin moin

It is actually depending on www/tidy-html5 (properly), but due to the library name conflict with www/tidy-lib the wrong so is picked up.


mfg Tobias
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-08-30 20:06:09 UTC 
A commit references this bug:

Author: tcberner
Date: Fri Aug 30 20:05:28 UTC 2019
New revision: 510288
URL: https://svnweb.freebsd.org/changeset/ports/510288

Log:
  x11-fm/konqueror: fix dependency on www/tidy-html5

  - Due to the workaround for the library name conflict between
    www/tidy-html5 (the wanted dependency) and www/tidy-lib,
    the build system was picking up the wrong shared library.

  PR:		240210
  Reported by:	Ting-Wei Lan <lantw44@gmail.com>

Changes:
  head/x11-fm/konqueror/Makefile
  head/x11-fm/konqueror/files/
  head/x11-fm/konqueror/files/patch-plugins_validators_FindLibTidy.cmake
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2019-08-30 20:06:24 UTC 
A fix has been committed -- Thanks for the report.

mfg Tobias