Created attachment 207075 [details] patch Building with GCC9 fails with: src/util.hh: In instantiation of ‘std::set<typename M::key_type> keys(const M&) [with M = std::map<CBit, bool>; typename M::key_type = CBit]’: src/chipdb.cc:73:23: required from here src/util.hh:191:24: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move] 191 | return std::move(keys); | ^ src/util.hh:191:24: note: remove ‘std::move’ call As reported at https://github.com/YosysHQ/arachne-pnr/issues/134 Add -Wno-error=pessimizing-move to CFLAGS for GCC build.
Reporter is committer, assign accordingly @Piotr Could you do this (assign yourself) for issues you report where MAINTAINER != committer please? Thanks! Feel free also do to so (assign yourself) in cases where MAINTAINER == committer and maintainer timeout (14+ days) Note also: * Build fixes don't require maintainer approval, as they are implicitly: Approved by: portmgr (blanket: build fix) Approved by: ports-secteam (blanket: build fix) - For MFH's * -Werror removal also doesn't require maintainer approval, as it is implicitly: Approved by: portmgr (blanket: ports/framework compliance) Approved by: ports-secteam (blanket: ports/framework compliance) - For MFH's
(In reply to Kubilay Kocak from comment #1) > * Build fixes don't require maintainer approval, as they are implicitly: > > Approved by: portmgr (blanket: build fix) > Approved by: ports-secteam (blanket: build fix) - For MFH's Uh ... no? These are fixes that *only* affect GCC-based installations. Several maintainers have objected to the way we have been trying to do these. > * -Werror removal also doesn't require maintainer approval, as it is implicitly: > > Approved by: portmgr (blanket: ports/framework compliance) > Approved by: ports-secteam (blanket: ports/framework compliance) - For MFH's Uh ... where does it say that?
Mentor approval (once maintainer acts). It builds for me on a clang-based system.
A commit references this bug: Author: pkubaj Date: Mon Sep 16 11:22:54 UTC 2019 New revision: 512167 URL: https://svnweb.freebsd.org/changeset/ports/512167 Log: devel/arachne-pnr: fix build with GCC-based architectures Building with GCC9 fails with: src/util.hh: In instantiation of ?std::set<typename M::key_type> keys(const M&) [with M = std::map<CBit, bool>; typename M::key_type = CBit]?: src/chipdb.cc:73:23: required from here src/util.hh:191:24: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move] 191 | return std::move(keys); | ^ src/util.hh:191:24: note: remove ?std::move? call As reported at https://github.com/YosysHQ/arachne-pnr/issues/134 Add -Wno-error=pessimizing-move to CFLAGS for GCC build. PR: 240256 Approved by: linimon (mentor), jsorocil@gmail.com (maintainer timeout) Changes: head/devel/arachne-pnr/Makefile