Created attachment 207155 [details] svn(1) diff against the ports tree Two problems lie in ${EDELIB_WRKSRC}/sslib/gen-c-string.sh sed usage: - \s is a GNU extension, this is trivially replaced with [[:space:]], HOWEVER: - The next expression uses \t and expects a tab, but this will not happen with our sed. \s is caught by bug #229925 that forbids escaping ordinary characters that have no extra meaning to lessen the stress of later adding special behavior to some of these escape sequences. \t, however, will just silently do the wrong thing. Switch this over to gsed for now; a pass will be done later to check out every port with BUILD_DEPENDS containing gsed to evaluate whether we're ready for them to use base sed or not.
^Triage: Reporter is committer, assign accordingly
Comment on attachment 207155 [details] svn(1) diff against the ports tree Approved by: portmgr (blanket: unmaintained port)
Comment on attachment 207155 [details] svn(1) diff against the ports tree If the changes pass QA (portlint, poudriere) Approved by: koobs (ports)
Created attachment 207176 [details] svn(1) diff against the ports tree New proposed commit message: Two problems lie in ${EDELIB_WRKSRC}/sslib/gen-c-string.sh sed usage: - \s is a GNU extension, this is trivially replaced with [[:space:]], HOWEVER: - The next expression uses \t and expects a tab, but this will not happen with our sed. \s is caught by bug #229925 that forbids escaping ordinary characters that have no extra meaning to lessen the stress of later adding special behavior to some of these escape sequences. \t, however, will just silently do the wrong thing. Switch this over to gsed for now; a pass will be done later to check out every port with BUILD_DEPENDS containing gsed to evaluate whether we're ready for them to use base sed or not. Spacing has been adjusted to move SHEBANG_FILES into a new block with BINARY_ALIAS to make portlint a little less angry.
Two problems lie in ${EDELIB_WRKSRC}/sslib/gen-c-string.sh sed usage: - \s is a GNU extension, this is trivially replaced with [[:space:]], HOWEVER: - The next expression uses \t and expects a tab, but this will not happen with our sed. \s is caught by bug #229925 that forbids escaping ordinary characters that have no extra meaning to lessen the stress of later adding special behavior to some of these escape sequences. \t, however, will just silently do the wrong thing. Switch this over to gsed for now; a pass will be done later to check out every port with BUILD_DEPENDS containing gsed to evaluate whether we're ready for them to use base sed or not. QA: * portlint: OK (minor warnings that should be addressed separately) * testport: OK (poudriere: 13.0-CURRENT and 12.0-RELEASE, amd64) * diffoscope: OK (only minor metadata changes to package)
A commit references this bug: Author: kevans Date: Fri Sep 6 21:18:49 UTC 2019 New revision: 511364 URL: https://svnweb.freebsd.org/changeset/ports/511364 Log: x11-wm/ede: Add sed=gsed Two problems lie in ${EDELIB_WRKSRC}/sslib/gen-c-string.sh sed usage: - \s is a GNU extension, this is trivially replaced with [[:space:]], HOWEVER: - The next expression uses \t and expects a tab, but this will not happen with our sed. \s was caught by the patch in bug #229925 that forbids escaping ordinary characters that have no extra meaning to lessen the stress of later adding special behavior to some of these escape sequences. \t, however, will just silently do the wrong thing. Switch this over to gsed for now; a pass will be done later to check out every port with BUILD_DEPENDS containing gsed to evaluate whether we're ready for them to use base sed or not. QA: * portlint: OK (minor warnings that should be addressed separately) * testport: OK (poudriere: 13.0-CURRENT and 12.0-RELEASE, amd64) * diffoscope: OK (only minor metadata changes to package) PR: 240312 Approved by: koobs (ports) Changes: head/x11-wm/ede/Makefile