Bug 240317 - www/grafana6: Switch to USES=go:modules, fix build with go1.13
Summary: www/grafana6: Switch to USES=go:modules, fix build with go1.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-03 19:01 UTC by Dmitri Goutnik
Modified: 2019-09-08 12:08 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (hiyorin)

Attachments
patch file (2.96 KB, patch)
2019-09-03 19:01 UTC, Dmitri Goutnik 		dmgk: maintainer-approval? (hiyorin)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-09-03 19:01:57 UTC 
Created attachment 207162 [details]
patch file

===>  Building for grafana6-6.3.3_1
$GOPATH/go.mod exists but should not
*** Error code 1

- Switch to USES=go:modules, this also fixes the build with go1.13
- Remove custom targets

QA:
  poudriere testport: OK (120a-go1.12.9, 120a-go-devel)
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2019-09-04 20:11:46 UTC 
testbuilds with go 1.13 look fine as well.
Comment 2 nbari 2019-09-06 16:49:55 UTC 
What about take advantage of this and upgrade to the lates 6.3.5
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-09-08 11:56:53 UTC 
(In reply to nbari from comment #2)
Please open a new PR for that with a patch.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-09-08 12:08:30 UTC 
A commit references this bug:

Author: tobik
Date: Sun Sep  8 12:08:16 UTC 2019
New revision: 511566
URL: https://svnweb.freebsd.org/changeset/ports/511566

Log:
  www/grafana6: Switch to USES=go:modules, fix build with go1.13

  ===>  Building for grafana6-6.3.3_1
  $GOPATH/go.mod exists but should not
  *** Error code 1

  - Remove custom build and install targets

  PR:		240317
  Submitted by:	Dmitri Goutnik <dg@syrec.org>
  Pointy hat:	jlaffaye

Changes:
  head/www/grafana6/Makefile