Bug 240631 - www/p5-WWW-Curl: Fix build on GCC architectures
Summary: www/p5-WWW-Curl: Fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-09-17 09:23 UTC by Piotr Kubaj
Modified: 2019-09-25 20:56 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch (755 bytes, patch)
2019-09-17 09:23 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (sunpoet)
koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-09-17 09:23:35 UTC 
Created attachment 207553 [details]
patch

When building with GCC:
Curl.xs:76: error: expected '{' before 'void'

Remove "struct" to fix build.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-17 09:26:18 UTC 
This should be sent upstream
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-17 09:27:11 UTC 
Comment on attachment 207553 [details]
patch

@Piotr Build fixes are:

Approved by: portmgr (blanket: build fix)
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2019-09-17 17:24:37 UTC 
Mentor approval (pending maintainer review): builds on ppcports.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-09-25 20:55:18 UTC 
A commit references this bug:

Author: sunpoet
Date: Wed Sep 25 20:55:02 UTC 2019
New revision: 512855
URL: https://svnweb.freebsd.org/changeset/ports/512855

Log:
  Fix build on powerpc

  PR:		240631
  Submitted by:	pkubaj

Changes:
  head/www/p5-WWW-Curl/files/patch-Curl.xs
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-09-25 20:56:15 UTC 
Committed. Thanks!