Bug 240681 - games/chessx: Update to 1.5.0, take maintainership
Summary: games/chessx: Update to 1.5.0, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL: https://sourceforge.net/p/chessx/code...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-19 10:18 UTC by Lorenzo Salvadore
Modified: 2019-09-26 16:23 UTC (History)
1 user (show)

See Also:


Attachments
chessx 1.5.0 (1.21 KB, patch)
2019-09-19 10:18 UTC, Lorenzo Salvadore
salvadore: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2019-09-19 10:18:06 UTC
Created attachment 207621 [details]
chessx 1.5.0

- Update to 1.5.0.
- Take maintainership.
- Change "qmake:outsource" in "qmake" only: outsource build is broken and unnecessary.
- Remove "USES=shared-mime-info" that looks to be useless (poudriere suggests it is).

Changelog:
https://sourceforge.net/p/chessx/code/HEAD/tree/tags/release-1-5-0/ChangeLog.txt

Tested successfully on 12.1-PRERELEASE r352242 and with poudriere on {11.3,12.0}-RELEASE {i386,amd64}.
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2019-09-19 10:19:22 UTC
I forgot the patch also adds USES=gl and USE_GL= gl.
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2019-09-25 18:25:04 UTC
Hi,

The submitted patch is not working for the following reasons :

- some of the patches are not required anymore, you probably
  remove the files without performing an svn rm
- xorg un the USE section must be followed by a USE_XORG 
  with the list of required modules. Otherwise it will be removed.

Those two points are not blockers for the port adoption but
has to be corrected before commit :).

I'm currently currently running the tests with a modified version
or your patch, if everything is fine, I will commit it.

Cheers,
-- rodrigo
Comment 3 Lorenzo Salvadore freebsd_committer freebsd_triage 2019-09-25 18:40:47 UTC
(In reply to Rodrigo Osorio from comment #2)

Thank you very much. If anything more needs to be corrected let me know :)
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-09-26 16:22:27 UTC
A commit references this bug:

Author: rodrigo
Date: Thu Sep 26 16:21:26 UTC 2019
New revision: 512904
URL: https://svnweb.freebsd.org/changeset/ports/512904

Log:
  Update games/chessx to 1.5.0 and take maintainership

  Changelog: http://chessx.sourceforge.net/node/71

  PR:		240681
  Submitted by:	Lorenzo Salvadore <phascolarctos@protonmail.ch>

Changes:
  head/games/chessx/Makefile
  head/games/chessx/distinfo
  head/games/chessx/files/patch-src_dialogs_preferences.cpp
  head/games/chessx/files/patch-src_dialogs_savedialog.cpp
  head/games/chessx/files/patch-src_gui_gamewindow.cpp
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2019-09-26 16:23:31 UTC
Committed with changes, thanks