Bug 240696 - databases/p5-Tie-LevelDB: fix build on powerpc* with clang
Summary: databases/p5-Tie-LevelDB: fix build on powerpc* with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-19 21:42 UTC by Piotr Kubaj
Modified: 2019-09-30 04:28 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch (335 bytes, patch)
2019-09-19 21:42 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (sunpoet)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-09-19 21:42:23 UTC 
Created attachment 207639 [details]
patch

powerpc* architectures soon switch to LLVM. Fix build when using LLVM.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-09-20 16:39:55 UTC 
Approved as mentor pending maintainer review.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-09-29 10:33:42 UTC 
I would like to use CFLAGS_${ARCH} instead.

Index: Makefile
===================================================================
--- Makefile    (revision 513215)
+++ Makefile    (working copy)
@@ -23,6 +23,9 @@
 USES=          compiler:c++11-lang gmake localbase perl5
 USE_PERL5=     configure

+CFLAGS_powerpc=        -DLEVELDB_CSTDATOMIC_PRESENT
+CFLAGS_powerpc64=      -DLEVELDB_CSTDATOMIC_PRESENT
+CFLAGS_powerpcspe=     -DLEVELDB_CSTDATOMIC_PRESENT
 MAKE_ARGS=     CC="${CXX}"

 .include <bsd.port.pre.mk>
@@ -29,8 +32,6 @@

 .if ${CHOSEN_COMPILER_TYPE} == clang
 CFLAGS+=       -Wno-reserved-user-defined-literal
-.else
-CFLAGS+=       -DLEVELDB_CSTDATOMIC_PRESENT
 .endif

 post-patch:
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-09-30 04:19:33 UTC 
A commit references this bug:

Author: sunpoet
Date: Mon Sep 30 04:19:23 UTC 2019
New revision: 513310
URL: https://svnweb.freebsd.org/changeset/ports/513310

Log:
  Fix build on powerpc* with Clang

  PR:		240696
  Submitted by:	pkubaj

Changes:
  head/databases/p5-Tie-LevelDB/Makefile
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-09-30 04:28:59 UTC 
Committed. Thanks!