Bug 240913 - Mk/Uses/motif.mk: Remove -lXp from MOTIFLIB
Summary: Mk/Uses/motif.mk: Remove -lXp from MOTIFLIB
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Niclas Zeising
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-29 07:28 UTC by Niclas Zeising
Modified: 2019-09-29 20:04 UTC (History)
2 users (show)

See Also:

Attachments
remove -lXp from MOTIFLIB (414 bytes, patch)
2019-09-29 07:28 UTC, Niclas Zeising 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niclas Zeising freebsd_committer freebsd_triage 2019-09-29 07:28:54 UTC 
Created attachment 207929 [details]
remove -lXp from MOTIFLIB

libXp is going away, it is deprecated upstream, and the extension it supports hasn't been in xserver for quite some time.  Mk/Uses/motif.mk hardcodes -lXp for everything that uses Motif, unless MOTIFLIB is overridden.  Attached patch removed this lib from MOTIFLIB.

I've run local builds with everything with USES=motif and there is no fallout, I don't think an exp-run is needed, but motif.mk is owned by portmgr@, so I'd like to get approval for the change.

With this change, the remaining ports that depend on libXp can be fixed.
Comment 1 Steve Wills freebsd_committer freebsd_triage 2019-09-29 19:44:49 UTC 
Looks fine, approved.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-09-29 19:52:50 UTC 
A commit references this bug:

Author: zeising
Date: Sun Sep 29 19:52:21 UTC 2019
New revision: 513266
URL: https://svnweb.freebsd.org/changeset/ports/513266

Log:
  Uses/motif.mk: Don't add -lXp to MOTIFLIB

  Don't add -lXp, linking against libXp, to the default MOTIFLIB.
  With this fix, it is easier to fix the remaining ports that depend on libXp,
  which is deprecated.

  PR:		240913
  Approved by:	portmgr (swills)

Changes:
  head/Mk/Uses/motif.mk