Bug 240930 - multimedia/emby-server: Add pidfile to rc file
Summary: multimedia/emby-server: Add pidfile to rc file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jan Beich
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2019-09-30 06:36 UTC by Maxime Gauduin
Modified: 2019-12-18 22:05 UTC (History)
1 user (show)

See Also:
koobs: merge-quarterly?

Attachments
ports diff (1.02 KB, patch)
2019-09-30 06:36 UTC, Maxime Gauduin 		alucryd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Gauduin 2019-09-30 06:36:09 UTC 
Created attachment 207952 [details]
ports diff

The pidfile line is missing, causing other mono programs to be detected in place of emby.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-30 06:41:34 UTC 
Thank you for the report and patch Maxime

Please use the attachment flag: maintainer-approval (set to +) to signify approval of patches for ports you maintain
Comment 2 Maxime Gauduin 2019-09-30 06:53:05 UTC 
Oh, I thought maintainer-feedback was the one. Thank you for the heads up, just added the flag.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-12-18 22:00:53 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Dec 18 22:00:10 UTC 2019
New revision: 520400
URL: https://svnweb.freebsd.org/changeset/ports/520400

Log:
  multimedia/emby-server: define pidfile in rc.d script

  Without pidfile other Mono applications maybe detected.

  PR:		240930
  Submitted by:	Maxime Gauduin (maintainer)

Changes:
  head/multimedia/emby-server/Makefile
  head/multimedia/emby-server/files/emby-server.in
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-12-18 22:02:57 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Dec 18 22:02:46 UTC 2019
New revision: 520403
URL: https://svnweb.freebsd.org/changeset/ports/520403

Log:
  MFH: r520400

  multimedia/emby-server: define pidfile in rc.d script

  Without pidfile other Mono applications maybe detected.

  PR:		240930
  Submitted by:	Maxime Gauduin (maintainer)
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2019Q4/
  branches/2019Q4/multimedia/emby-server/Makefile
  branches/2019Q4/multimedia/emby-server/files/emby-server.in