Bug 240975 - audio/streamripper: requesting maintainership
Summary: audio/streamripper: requesting maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-01 17:34 UTC by Bryan Erickson
Modified: 2019-10-23 00:19 UTC (History)
1 user (show)

See Also:

Attachments
Makefile patch which points to the CDK port. (1.96 KB, patch)
2019-10-21 07:52 UTC, Bryan Erickson 		freebsdports: maintainer-approval+
Details | Diff
Updated patch for streamripper Makefile with CDK_VERSION removed (2.28 KB, patch)
2019-10-21 16:46 UTC, Bryan Erickson 		freebsdports: maintainer-approval+
Details | Diff
Patch to remove CDK file hash from distinfo (480 bytes, patch)
2019-10-21 16:48 UTC, Bryan Erickson 		freebsdports: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Erickson 2019-10-01 17:34:03 UTC 
I'd offer to submit a patch, but I can't recreate the fetch failure for the port. It also compiles on 12.0-RELEASE-p10 without issues.


===>  License GPLv2 accepted by the user
===>   streamripper-1.64.6_5 depends on file: /usr/local/sbin/pkg - found
=> streamripper-1.64.6.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://downloads.sourceforge.net/project/streamripper/streamripper%20%28current%29/1.64.6/streamripper-1.64.6.tar.gz
streamripper-1.64.6.tar.gz                             879 kB 1512 kBps    01s
===> Fetching all distfiles required by streamripper-1.64.6_5 for building
===>  Extracting for streamripper-1.64.6_5
=> SHA256 Checksum OK for streamripper-1.64.6.tar.gz.
=> SHA256 Checksum OK for cdk-5.0-20060507.tgz.
/bin/mv /usr/ports/audio/streamripper/work/cdk-5.0-20060507 /usr/ports/audio/streamripper/work/streamripper-1.64.6
===>  Patching for streamripper-1.64.6_5
===>  Applying FreeBSD patches for streamripper-1.64.6_5
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-10-06 13:36:44 UTC 
A commit references this bug:

Author: meta
Date: Sun Oct  6 13:36:23 UTC 2019
New revision: 513886
URL: https://svnweb.freebsd.org/changeset/ports/513886

Log:
  audio/streamripper: Assign new maintainer

  - Extend expiry date to give maintainer grace time to fix unfetchable issue

  PR:		240975
  Submitted by:	Bryan Erickson <freebsdports@xorcara.com>

Changes:
  head/audio/streamripper/Makefile
  head/audio/streamripper/distinfo
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2019-10-06 16:17:01 UTC 
(In reply to Bryan Erickson from comment #0)
Hi!

Assigned to you. BTW, it seems cdk-5.0-20060507.tgz can be found only on FreeBSD distcache. streamripper-1.64.6.tar.gz isn't the issue.

I think https://invisible-mirror.net/ is the place where cdk is put. cdk-5.0-20060507.tgz can be found here:
https://invisible-mirror.net/archives/cdk/cdk-5.0-20060507.tgz

However, I'm still not this port fetches cdk-5.0-20060507.  Is it possible to make this port to depend on devel/cdk?
Comment 3 Bryan Erickson 2019-10-14 01:41:24 UTC 
(In reply to Koichiro Iwao from comment #2)

Hey Koichiro;

I'll take a look at having it point to the cdk port. I looked at he versions and they appear to match, so there shouldn't be an issue there. I'm just reviewing the ports maintainer guide to see how to make that change and make a patch.
Comment 4 Bryan Erickson 2019-10-21 07:52:37 UTC 
Created attachment 208478 [details]
Makefile patch which points to the CDK port.

This is the MakeFile patch. I could include a patch for the removal of the patch-cdk-5.0.2006507_configure under files for the port, but I just deleted it. I don't know what the procedure is for that instance.
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2019-10-21 09:33:36 UTC 
(In reply to Bryan Erickson from comment #4)
The reference to CDK_VERSION is left in the Makefile.
Comment 6 Bryan Erickson 2019-10-21 16:46:59 UTC 
Created attachment 208488 [details]
Updated patch for streamripper Makefile with CDK_VERSION removed
Comment 7 Bryan Erickson 2019-10-21 16:48:05 UTC 
Created attachment 208489 [details]
Patch to remove CDK file hash from distinfo
Comment 8 Bryan Erickson 2019-10-21 16:49:49 UTC 
(In reply to Koichiro Iwao from comment #5)

Thanks for catching that. I did another update, and the port compiles/runs after making the changes.
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-10-23 00:17:32 UTC 
A commit references this bug:

Author: meta
Date: Wed Oct 23 00:16:38 UTC 2019
New revision: 515234
URL: https://svnweb.freebsd.org/changeset/ports/515234

Log:
  audio/streamripper: Unbreak, use devel/cdk instead of its own

  PR:		240975
  Submitted by:	Bryan Erickson <freebsdports@xorcara.com>

Changes:
  head/audio/streamripper/Makefile
  head/audio/streamripper/files/
Comment 10 Koichiro Iwao freebsd_committer freebsd_triage 2019-10-23 00:19:44 UTC 
Committed everything, thanks!