Bug 241530 - sysutils/screen: update from 4.6.2_3 to 4.7.0_1 broke utx reporting
Summary: sysutils/screen: update from 4.6.2_3 to 4.7.0_1 broke utx reporting
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-28 00:22 UTC by Henry
Modified: 2019-10-29 16:58 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
Instead of using pututline() use addToUtmp() (1012 bytes, patch)
2019-10-28 03:45 UTC, Cy Schubert 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry 2019-10-28 00:22:14 UTC 
On both 11.3 and 12.0 the update to 4.7.0_1 broke reporting of any and all screen sessions started by users via standard tools like w/who.
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2019-10-28 03:45:36 UTC 
Created attachment 208644 [details]
Instead of using pututline() use addToUtmp()
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2019-10-28 03:46:27 UTC 
You can approximate the patch by chmod u-s the screen binary.
Comment 3 Henry 2019-10-28 18:22:38 UTC 
Without suid root (ie 755) screen will at least not wipe out the parent tty session.

However 4.6.2 (with suid) logged multiple per tty/terminal in utx.

This work around does not restore that functionality.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-10-29 04:24:19 UTC 
A commit references this bug:

Author: cy
Date: Tue Oct 29 04:23:51 UTC 2019
New revision: 515953
URL: https://svnweb.freebsd.org/changeset/ports/515953

Log:
  Correctly identify utmpx support in FreeBSD.

  - FreeBSD's utmpx is incorrectly identified in ./configure.
  - Because of the falsely identified utmpx support in the ./configure
    script, a previously applied patch, which didn't work, is no longer
    needed.

  PR:		241530
  Reported by:	Henry David Bartholomew <PopularMoment@protonmail.com>
  		Daniel Drinnon <ddrinnon@cdor.net>

Changes:
  head/sysutils/screen/Makefile
  head/sysutils/screen/files/patch-configure
  head/sysutils/screen/files/patch-utmp.c
Comment 5 Cy Schubert freebsd_committer freebsd_triage 2019-10-29 12:30:31 UTC 
fixed
Comment 6 Henry 2019-10-29 16:58:24 UTC 
Thank you for the prompt fix.