Created attachment 208783 [details] [patch] fix build failures for non-default PREFIX If one builds with a non-default PREFIX (e.g., make PREFIX=/opt stage stage-qa check-plist WITH="PERL NLS"), the build fails. First failure shows up due to wrong location for perl module (if PERL is on). ========================= . . /usr/bin/strip /wrkdirs/usr/ports/databases/rrdtool/work-py36/stage/opt/rrdtool-1.7.2/lib/perl5/site_perl/mach/5.30/auto/RRDs/RRDs.so strip: open /wrkdirs/usr/ports/databases/rrdtool/work-py36/stage/opt/rrdtool-1.7.2/lib/perl5/site_perl/mach/5.30/auto/RRDs/RRDs.so failed: No such file or directory *** Error code 1 Stop. make: stopped in /usr/ports/databases/rrdtool ======================== After fixing that (see PERL_MAKE_ARGS in patch), the next failure shows up if NLS is on: ======================== . . checking for GNU gettext in libc... no checking for iconv... no, consider installing GNU libiconv checking for GNU gettext in libintl... no checking whether to use NLS... no . . ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: share/locale/fr/LC_MESSAGES/rrdtool.mo Error: Missing: share/locale/hu/LC_MESSAGES/rrdtool.mo ===> Error: Plist issues found. ===> Warning: Test was done with PREFIX != LOCALBASE ===> Warning: The port may not be properly installing into PREFIX *** Error code 1 ======================== Attached patch fixes those failures. QA: - poudriere testport (ok) - portlint (ok, no new warnings)
A commit references this bug: Author: zeising Date: Sat Nov 2 22:07:38 UTC 2019 New revision: 516372 URL: https://svnweb.freebsd.org/changeset/ports/516372 Log: databases/rrdtool: Fix with nondefault PREFIX Fix the build and stage of databases/rrdtool when using a nondefault PREFIX. PR: 241659 Submitted by: John Hein MFH: 2019Q4 Changes: head/databases/rrdtool/Makefile
Committed, pending MFH.
MFH never happened, but it's in the quarterly branch anyway, since a new one was created January 1. No need to keep this open. Thank you for the sumbission John!