Bug 241819 - audio/siren: Fix build issues, use FFmpeg by default, make plugins optional
Summary: audio/siren: Fix build issues, use FFmpeg by default, make plugins optional
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-09 10:55 UTC by Daniel Engberg
Modified: 2019-12-04 20:48 UTC (History)
2 users (show)

See Also:

Attachments
Patch (3.58 KB, patch)
2019-11-09 10:55 UTC, Daniel Engberg 		no flags Details | Diff
Poudriere log (38.52 KB, text/plain)
2019-11-09 10:58 UTC, Daniel Engberg 		no flags Details
Patch v2 (3.58 KB, patch)
2019-12-04 19:46 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2019-11-09 10:55:21 UTC 
Created attachment 208993 [details]
Patch

Make all plugins optional
Fix build issue with (lib)faad
Consolidate input dependencies by using FFmpeg as default option
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2019-11-09 10:58:00 UTC 
Created attachment 208994 [details]
Poudriere log
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2019-11-09 11:07:31 UTC 
Moin moin 

Is it sensible to have most of the plugins off by default? 
As that implies that possibly most users will need to build that port themselves rather than use the pkg from the repo.


mfg Tobias
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2019-11-09 11:56:57 UTC 
FFmpeg already supports all inputs provided by separate libraries and is faster in terms of processing power in the majority of all cases not to mention actively maintained compared to some of the libraries previously used.

Ref (search for ip_ffmpeg_extensions): https://www.kariliq.nl/hg/siren/file/ip/ffmpeg.c.html
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2019-12-04 14:49:09 UTC 
Any progess on this one?
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2019-12-04 17:02:12 UTC 
Sorry fell through, I'll look at it tonight
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2019-12-04 19:18:26 UTC 
Could you regenerate the patch against the current tree?

mfg Tobias
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2019-12-04 19:46:58 UTC 
Created attachment 209705 [details]
Patch v2
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2019-12-04 19:47:45 UTC 
Fixed
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-12-04 20:10:58 UTC 
A commit references this bug:

Author: tcberner
Date: Wed Dec  4 20:10:18 UTC 2019
New revision: 519043
URL: https://svnweb.freebsd.org/changeset/ports/519043

Log:
  audio/siren: Use FFmpeg by default, make plugins optional

  - ffmpeg already handles all the other inputs.

  PR:		241819
  Submitted by:	daniel.engberg.lists@pyret.net

Changes:
  head/audio/siren/Makefile
  head/audio/siren/pkg-plist
Comment 10 Daniel Engberg freebsd_committer freebsd_triage 2019-12-04 20:48:53 UTC 
Thanks