Bug 241879 - converters/recode: recode.info comes out empty
Summary: converters/recode: recode.info comes out empty
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Sivachenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-11 13:24 UTC by Victor Sudakov
Modified: 2020-09-05 06:36 UTC (History)
3 users (show)

See Also:
mandree: maintainer-feedback-


Attachments
A poudriere build log (438.56 KB, text/plain)
2019-11-11 13:24 UTC, Victor Sudakov
no flags Details
A fresh poudriere build log (444.71 KB, text/plain)
2020-05-07 10:23 UTC, Victor Sudakov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Sudakov 2019-11-11 13:24:52 UTC
Created attachment 209056 [details]
A poudriere build log

After compilation in poudriere, recode.info is empty:

root@test1:~ # pkg info -l converters/recode
recode-3.6_14:
	/usr/local/bin/recode
	/usr/local/include/recode.h
	/usr/local/include/recodext.h
	/usr/local/lib/librecode.a
	/usr/local/lib/librecode.so
	/usr/local/lib/librecode.so.3
	/usr/local/lib/librecode.so.3.0.6
	/usr/local/man/man1/recode.1.gz
	/usr/local/share/info/recode.info
	/usr/local/share/locale/da/LC_MESSAGES/recode.mo
	/usr/local/share/locale/de/LC_MESSAGES/recode.mo
	/usr/local/share/locale/el/LC_MESSAGES/recode.mo
	/usr/local/share/locale/es/LC_MESSAGES/recode.mo
	/usr/local/share/locale/fr/LC_MESSAGES/recode.mo
	/usr/local/share/locale/gl/LC_MESSAGES/recode.mo
	/usr/local/share/locale/it/LC_MESSAGES/recode.mo
	/usr/local/share/locale/nl/LC_MESSAGES/recode.mo
	/usr/local/share/locale/pl/LC_MESSAGES/recode.mo
	/usr/local/share/locale/pt/LC_MESSAGES/recode.mo
	/usr/local/share/locale/ru/LC_MESSAGES/recode.mo
	/usr/local/share/locale/sl/LC_MESSAGES/recode.mo
	/usr/local/share/locale/sv/LC_MESSAGES/recode.mo
root@test1:~ # file /usr/local/share/info/recode.info
/usr/local/share/info/recode.info: empty
root@test1:~ #
Comment 1 Walter Schwarzenfeld freebsd_triage 2019-11-16 01:43:51 UTC
There is a new releas 3.7.6:

https://github.com/rrthomas/recode/releases
Comment 2 Victor Sudakov 2020-05-06 14:43:30 UTC
Ping!
Comment 3 Dmitry Sivachenko freebsd_committer freebsd_triage 2020-05-07 09:48:45 UTC
Does it still an issue?  I fixed that 2019-11-21 but forgot about this PR.
Comment 4 Victor Sudakov 2020-05-07 09:52:12 UTC
Of course it still is:

# pkg info -o recode
recode-3.6_14                  converters/recode
# file /usr/local/share/info/recode.info
/usr/local/share/info/recode.info: empty
#
Comment 5 Dmitry Sivachenko freebsd_committer freebsd_triage 2020-05-07 10:05:54 UTC
Well, something is probably broken in your install then...
I just re-checked and this file is not empty for me.

What is the output for 'makeinfo recode.texi' run in ports/converters/recode/work/Recode-3.6/doc/ ?
Comment 6 Victor Sudakov 2020-05-07 10:13:13 UTC
(In reply to Dmitry Sivachenko from comment #5)
Dunno, the package I showed above was installed from the default FreeBSD package repository on my desktop system. Never bothered to compile from ports.

Would you like me to run poudriere testport on converters/recode ?
Comment 7 Dmitry Sivachenko freebsd_committer freebsd_triage 2020-05-07 10:15:13 UTC
Well, may be you are using an old package? Built before the fix was committed?
Can you please try something recently built?
Comment 8 Victor Sudakov 2020-05-07 10:23:27 UTC
Created attachment 214227 [details]
A fresh poudriere build log

Complains about WARNING: `makeinfo' is missing on your system.
Comment 9 Victor Sudakov 2020-05-07 10:28:06 UTC
root@121amd64-default:/wrkdirs/usr/ports/converters/recode/work/Recode-3.6/doc # makeinfo recode.texi
makeinfo: Command not found.
root@121amd64-default:/wrkdirs/usr/ports/converters/recode/work/Recode-3.6/doc # 


As recent port as I can get. Probably a missing build dependency on makeinfo somewhere.
Comment 10 Victor Sudakov 2020-05-07 14:31:01 UTC
The build should probably depend on print/texinfo. I have not found makeinfo in the base system either in 11.3 or in 12.1

If for some reason you already have makeinfo (from print/texinfo) installed when building recode, you'll not be able to reproduce the problem.
Comment 11 commit-hook freebsd_committer freebsd_triage 2020-09-04 15:58:12 UTC
A commit references this bug:

Author: mandree
Date: Fri Sep  4 15:58:00 UTC 2020
New revision: 547547
URL: https://svnweb.freebsd.org/changeset/ports/547547

Log:
  converters/recode: fix info file, add LICENCE, quiet portlint/portclippy

  This has been broken for almost 10 months, and again 3 months of silence
  from the maintainer, so let me step in to just fix it for the nonce.

  - Add LICENSE=GPLv2+
  - Add USES=makeinfo to fix .info file in clean-room builds (poudriere) [1]
  - Reshuffle a few lines to please portclippy and portlint
  - Bump PORTREVISION to flush out the broken packages and force rebuild

  - Add DISABLED example to strip library in order to also please
    stage-qa with DEVELOPER=yes (would require maintainer approval),
    in post-install (just remove @: and the comment line to enable).

  PR:		241879 [1]
  Submitted by:	Victor Sudakov <vas@sibptus.ru> [1]
  Approved by:	portmgr@ (blanket, see MFH below)
  MFH:		2020Q3 (blanket LICENSE, dependencies to unbreak, modernization)

Changes:
  head/converters/recode/Makefile
Comment 12 commit-hook freebsd_committer freebsd_triage 2020-09-04 16:00:14 UTC
A commit references this bug:

Author: mandree
Date: Fri Sep  4 15:59:35 UTC 2020
New revision: 547548
URL: https://svnweb.freebsd.org/changeset/ports/547548

Log:
  MFH: r547547

  converters/recode: fix info file, add LICENCE, quiet portlint/portclippy

  This has been broken for almost 10 months, and again 3 months of silence
  from the maintainer, so let me step in to just fix it for the nonce.

  - Add LICENSE=GPLv2+
  - Add USES=makeinfo to fix .info file in clean-room builds (poudriere) [1]
  - Reshuffle a few lines to please portclippy and portlint
  - Bump PORTREVISION to flush out the broken packages and force rebuild

  - Add DISABLED example to strip library in order to also please
    stage-qa with DEVELOPER=yes (would require maintainer approval),
    in post-install (just remove @: and the comment line to enable).

  PR:		241879 [1]
  Submitted by:	Victor Sudakov <vas@sibptus.ru> [1]
  Approved by:	portmgr@ (blanket, see next line)
  Approved by:	ports-secteam@ (blanket: add dependency to fix broken .info, add LICENSE, fix portlint/portclippy issues)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/converters/recode/Makefile
Comment 13 Matthias Andree freebsd_committer freebsd_triage 2020-09-04 16:06:18 UTC
maintainer timeout (89 d)
Comment 14 Victor Sudakov 2020-09-05 06:36:05 UTC
Thank you Matthias, I'm glad this issue has finally been dealt with.