Bug 242467 - security/libpwquality: update to 1.4.2 (and more)
Summary: security/libpwquality: update to 1.4.2 (and more)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-06 00:39 UTC by Jung-uk Kim
Modified: 2020-07-01 13:28 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
Update to 1.4.2 (and more) (7.21 KB, patch)
2019-12-06 00:39 UTC, Jung-uk Kim 		no flags Details | Diff
Update to 1.4.2 and more (v2) (7.18 KB, patch)
2019-12-09 15:12 UTC, Jung-uk Kim 		no flags Details | Diff
Update to 1.4.2 and more (v3) (7.20 KB, patch)
2019-12-11 23:21 UTC, Jung-uk Kim 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jung-uk Kim freebsd_committer freebsd_triage 2019-12-06 00:39:37 UTC 
Created attachment 209745 [details]
Update to 1.4.2 (and more)

1.4.2 is available for a while now.  Excerpt from NEWS:

- Release 1.4.2 (10/31/2019)

* Fix regression in handling retry, enforce_for_root, and
  local_users_only options introduced with the previous
  release.

- Release 1.4.1 (9/17/2019)

* pam_pwquality: Abort the retry loop if user requests it.
* Allow setting retry, enforce_for_root, and local_users_only options
  in the pwquality.conf config file.
* Fix uninitialized memory in word distance calculations.
* Fix possible one byte buffer underflow when parsing the config file.
* Return default cracklib dictionary path if not overriden.
* Update translations from Zanata.

While I am at it, I added LICENSE stuff and OPTIONized NLS.
Comment 1 Ting-Wei Lan 2019-12-07 09:28:15 UTC 
Comment on attachment 209745 [details]
Update to 1.4.2 (and more)


>+LICENSE=	GPLv2+ LIBPWQUALITY
>+LICENSE_COMB=	dual
>+LICENSE_NAME_LIBPWQUALITY=	The libpwquality license
>+LICENSE_FILE_LIBPWQUALITY=	${WRKSRC}/COPYING
>+LICENSE_PERMS_LIBPWQUALITY=	dist-mirror no-dist-sell pkg-mirror no-pkg-sell auto-accept

The libpwquality license of looks like BSD 3-clause license. Why it is marked as no-dist-sell and no-pkg-sell?
Comment 2 Jung-uk Kim freebsd_committer freebsd_triage 2019-12-09 15:08:57 UTC 
(In reply to Ting-Wei Lan from comment #1)
Oops, copy-and-pasto.  Will fix.
Comment 3 Jung-uk Kim freebsd_committer freebsd_triage 2019-12-09 15:12:05 UTC 
Created attachment 209803 [details]
Update to 1.4.2 and more (v2)
Comment 4 Ting-Wei Lan 2019-12-11 16:04:07 UTC 
Comment on attachment 209803 [details]
Update to 1.4.2 and more (v2)

>+LICENSE=	GPLv2+ LIBPWQUALITY
>+LICENSE_COMB=	dual
>+LICENSE_NAME_LIBPWQUALITY=	The libpwquality license
>+LICENSE_FILE_LIBPWQUALITY=	${WRKSRC}/COPYING
>+LICENSE_PERMS_LIBPWQUALITY=	dist-mirror pkg-mirror auto-accept

Removing no-dist-sell and no-pkg-sell changes nothing. Not listing a permission means it is disallowed. I think you have to add dist-sell and pkg-sell to the list.
Comment 5 Jung-uk Kim freebsd_committer freebsd_triage 2019-12-11 23:21:14 UTC 
Created attachment 209879 [details]
Update to 1.4.2 and more (v3)

(In reply to Ting-Wei Lan from comment #4)
Done.
Comment 6 Ting-Wei Lan 2019-12-12 14:12:08 UTC 
Comment on attachment 209879 [details]
Update to 1.4.2 and more (v3)

The license permissions looks correct now.
Comment 7 Jung-uk Kim freebsd_committer freebsd_triage 2020-01-07 23:15:21 UTC 
Ping...  Any thoughts?
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2020-04-22 17:31:38 UTC 
Koop, is this something you can have a look at?
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2020-05-07 06:01:10 UTC 
Poudriere testport OK 12.1-RELEASE (AMD64)
Comment 10 commit-hook freebsd_committer freebsd_triage 2020-07-01 13:28:55 UTC 
A commit references this bug:

Author: lwhsu
Date: Wed Jul  1 13:28:12 UTC 2020
New revision: 540960
URL: https://svnweb.freebsd.org/changeset/ports/540960

Log:
  Update to 1.4.2

  Added LICENSE stuff and OPTIONized NLS.

  PR:		242467
  Submitted by:	jkim

Changes:
  head/security/libpwquality/Makefile
  head/security/libpwquality/distinfo
  head/security/libpwquality/pkg-plist