Bug 242657 - net-im/farstream: +++ UNFETCHABLE +++ Checksum mismatch error (Git version after downloaded patch changed)
Summary: net-im/farstream: +++ UNFETCHABLE +++ Checksum mismatch error (Git version af...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: patch-ready, regression
: 240906 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-12-16 02:00 UTC by Santhosh Raju
Modified: 2019-12-30 02:11 UTC (History)
7 users (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly?

Attachments
Regenerates distinfo to prevent checksum mismatch error. (658 bytes, patch)
2019-12-16 02:00 UTC, Santhosh Raju 		fox: maintainer-approval? (gnome)
 Details | Diff
move the fs-rtp-bitrate-adapter.c patch from a download to ${FILESDIR} to prevent similar breakage again (4.07 KB, patch)
2019-12-28 21:26 UTC, Matthias Andree 		kwm: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Santhosh Raju freebsd_committer freebsd_triage 2019-12-16 02:00:14 UTC 
Created attachment 209986 [details]
Regenerates distinfo to prevent checksum mismatch error.

It looks like the upstream git version changed and this is now causing checksum mismatch error during build.

I have attached a patch which regenerates distinfo to solve the issue.h
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-12-16 02:08:43 UTC 
Thanks for the report Santhosh

Can you diff the changes between git revisions and let us know what it finds
Comment 2 Santhosh Raju freebsd_committer freebsd_triage 2019-12-16 02:18:02 UTC 
Looking at the bottom of the patch

https://gitlab.collabora.com/farstream/farstream/commit/11dde55cbaf5179e8e1885cf1483e538a8d5a4a9.patch

It seems the version is currently 2.22.2

Based on this older bug report

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240906

The previous one seems to be 2.22.0
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2019-12-21 13:45:00 UTC 
I propose to read the actual patch which seems sane in a sense of not introducing backdoors or whatever, and then commit...
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2019-12-21 13:49:10 UTC 
Alternatively, the external patch isn't big, so could be hosted inside ${FILESDIR} to isolate the ports tree from further changes of the web hosting's Git version if the patch is generated on the fly.
Comment 5 Matthias Andree freebsd_committer freebsd_triage 2019-12-28 16:51:14 UTC 
bump - this is urgent
Comment 6 Matthias Andree freebsd_committer freebsd_triage 2019-12-28 21:26:43 UTC 
Created attachment 210293 [details]
move the fs-rtp-bitrate-adapter.c patch from a download to ${FILESDIR} to prevent similar breakage again

Since the patch file to be downloaded is apparently generated on-the-fly, contains a Git version and is thus prone to future distinfo SHA256 change again, and because it is a small patch, I am proposing to integrate it into the ports tree. I have reviewed the incurred changes and find them harmless. No backdoors or similar.

WARNING: This breaks some 40 downstream ports, so 
UNLESS I HEAR OBJECTIONS from portmgr@ or gnome@ by 2019-12-30T15:00Z (UTC), I will commit under "make unfetchable port fetchable" blanket so we don't start 2020 with a broken 2020Q1 ports tree.

I'd appreciate maintainer approval or commit though.

As a side effect, my patch adds LICENSE=LGPL21+
Comment 7 Matthias Andree freebsd_committer freebsd_triage 2019-12-28 21:30:11 UTC 
@koobs, more important to get this in in the first place, whether we merge for the final few days of 2019Q4 is a different matter.
Comment 8 Matthias Andree freebsd_committer freebsd_triage 2019-12-28 21:31:04 UTC 
*** Bug 240906 has been marked as a duplicate of this bug. ***
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-12-29 12:23:30 UTC 
A commit references this bug:

Author: mandree
Date: Sun Dec 29 12:22:31 UTC 2019
New revision: 521277
URL: https://svnweb.freebsd.org/changeset/ports/521277

Log:
  net-im/farstream: import patch to isolate from Git version updates

  ...on the download portal of the patch.

  PR:		242657
  Approved by:	gnome@ (kwm)

Changes:
  head/net-im/farstream/Makefile
  head/net-im/farstream/distinfo
  head/net-im/farstream/files/patch-11dde55cbaf5179e8e1885cf1483e538a8d5a4a9