Bug 242766 - games/glest: fix build on GCC architectures
Summary: games/glest: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mahdi Mokhtari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-21 13:49 UTC by Piotr Kubaj
Modified: 2020-01-04 20:25 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mmokhi)


Attachments
patch (894 bytes, patch)
2019-12-21 13:49 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (mmokhi)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-12-21 13:49:15 UTC
Created attachment 210102 [details]
patch

Building with GCC fails:
./mk/linux/glest_game/ai/ai_rule.cpp: In member function 'virtual bool Glest::Game::AiRuleMassiveAttack::test()':
./mk/linux/glest_game/ai/ai_rule.cpp:156:46: error: 'INT_MAX' was not declared in this scope
  156 |   return ai->beingAttacked(attackPos, field, INT_MAX);
      |                                              ^~~~~~~
./mk/linux/glest_game/ai/ai_rule.cpp:19:1: note: 'INT_MAX' is defined in header '<climits>'; did you forget to '#include <climits>'?
   18 | #include "leak_dumper.h"
  +++ |+#include <climits>
   19 | 
./mk/linux/glest_game/ai/ai_rule.cpp: In member function 'virtual bool Glest::Game::AiRuleExpand::test()':
./mk/linux/glest_game/ai/ai_rule.cpp:815:22: error: 'INT_MAX' was not declared in this scope
  815 |     int minDistance= INT_MAX;
      |                      ^~~~~~~
./mk/linux/glest_game/ai/ai_rule.cpp:815:22: note: 'INT_MAX' is defined in header '<climits>'; did you forget to '#include <climits>'?
...failed C++ ./build/powerpc64-portbld-freebsd12.1/optimize/glest_game/ai/ai_rule.o ...

Include climits in ai_rule.cpp to fix it.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-01-04 20:24:13 UTC
A commit references this bug:

Author: pkubaj
Date: Sat Jan  4 20:23:27 UTC 2020
New revision: 522057
URL: https://svnweb.freebsd.org/changeset/ports/522057

Log:
  games/glest: fix build on GCC architectures

  Building with GCC fails:
  ./mk/linux/glest_game/ai/ai_rule.cpp: In member function 'virtual bool Glest::Game::AiRuleMassiveAttack::test()':
  ./mk/linux/glest_game/ai/ai_rule.cpp:156:46: error: 'INT_MAX' was not declared in this scope
    156 |   return ai->beingAttacked(attackPos, field, INT_MAX);
        |                                              ^~~~~~~
  ./mk/linux/glest_game/ai/ai_rule.cpp:19:1: note: 'INT_MAX' is defined in header '<climits>'; did you forget to '#include <climits>'?
     18 | #include "leak_dumper.h"
    +++ |+#include <climits>
     19 |
  ./mk/linux/glest_game/ai/ai_rule.cpp: In member function 'virtual bool Glest::Game::AiRuleExpand::test()':
  ./mk/linux/glest_game/ai/ai_rule.cpp:815:22: error: 'INT_MAX' was not declared in this scope
    815 |     int minDistance= INT_MAX;
        |                      ^~~~~~~
  ./mk/linux/glest_game/ai/ai_rule.cpp:815:22: note: 'INT_MAX' is defined in header '<climits>'; did you forget to '#include <climits>'?
  ...failed C++ ./build/powerpc64-portbld-freebsd12.1/optimize/glest_game/ai/ai_rule.o ...

  Include climits in ai_rule.cpp to fix it.

  PR:		242766
  Approved by:	mmokhi (maintainer timeout)
  MFH:		2020Q1 (fix build blanket)

Changes:
  head/games/glest/files/patch-source_glest__game_ai_ai__rule.cpp
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-01-04 20:25:14 UTC
A commit references this bug:

Author: pkubaj
Date: Sat Jan  4 20:24:19 UTC 2020
New revision: 522058
URL: https://svnweb.freebsd.org/changeset/ports/522058

Log:
  MFH: r522057

  games/glest: fix build on GCC architectures

  Building with GCC fails:
  ./mk/linux/glest_game/ai/ai_rule.cpp: In member function 'virtual bool Glest::Game::AiRuleMassiveAttack::test()':
  ./mk/linux/glest_game/ai/ai_rule.cpp:156:46: error: 'INT_MAX' was not declared in this scope
    156 |   return ai->beingAttacked(attackPos, field, INT_MAX);
        |                                              ^~~~~~~
  ./mk/linux/glest_game/ai/ai_rule.cpp:19:1: note: 'INT_MAX' is defined in header '<climits>'; did you forget to '#include <climits>'?
     18 | #include "leak_dumper.h"
    +++ |+#include <climits>
     19 |
  ./mk/linux/glest_game/ai/ai_rule.cpp: In member function 'virtual bool Glest::Game::AiRuleExpand::test()':
  ./mk/linux/glest_game/ai/ai_rule.cpp:815:22: error: 'INT_MAX' was not declared in this scope
    815 |     int minDistance= INT_MAX;
        |                      ^~~~~~~
  ./mk/linux/glest_game/ai/ai_rule.cpp:815:22: note: 'INT_MAX' is defined in header '<climits>'; did you forget to '#include <climits>'?
  ...failed C++ ./build/powerpc64-portbld-freebsd12.1/optimize/glest_game/ai/ai_rule.o ...

  Include climits in ai_rule.cpp to fix it.

  PR:		242766
  Approved by:	mmokhi (maintainer timeout)
  Approved by:	portmgr (fix build blanket)

Changes:
_U  branches/2020Q1/
  branches/2020Q1/games/glest/files/patch-source_glest__game_ai_ai__rule.cpp