Bug 242813 - misc/xfce4-weather-plugin: Avoid to display warning message
Summary: misc/xfce4-weather-plugin: Avoid to display warning message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-22 19:33 UTC by Olivier Duchateau
Modified: 2019-12-26 19:45 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+


Attachments
Avoid warning in details window (3.13 KB, patch)
2019-12-22 19:33 UTC, Olivier Duchateau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2019-12-22 19:33:27 UTC
Created attachment 210155 [details]
Avoid warning in details window

In details window, a warning message is displaying, because locationforecastlst API is deprecated. This patch fixes this issue (switch to locationforecast API).

It is already reported to upstream (bugs 16268 [1], and 16271 [2]).

This patch contains also fix for panel >= 4.15.x (tested with panel 4.14 and 4.15).

Note: EOL of locationforecastlts is February 2020.

[1] https://bugzilla.xfce.org/show_bug.cgi?id=16268
[2] https://bugzilla.xfce.org/show_bug.cgi?id=16271
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2019-12-25 21:09:39 UTC
Thanks for the patch.

Looking at this.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-12-26 19:41:47 UTC
A commit references this bug:

Author: madpilot
Date: Thu Dec 26 19:41:28 UTC 2019
New revision: 520946
URL: https://svnweb.freebsd.org/changeset/ports/520946

Log:
  Import changes from upstream bug reaport to make xfce4-weather-plugin
  use newer API, and avoid a warning about the old API being deprecated.

  PR:		242813
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>

Changes:
  head/misc/xfce4-weather-plugin/Makefile
  head/misc/xfce4-weather-plugin/files/
  head/misc/xfce4-weather-plugin/files/patch-panel-plugin_weather.c
  head/misc/xfce4-weather-plugin/files/patch-panel-plugin_weather.h
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2019-12-26 19:45:12 UTC
Committed. Thanks!