Bug 242908 - devel/caf: fix build on GCC architectures
Summary: devel/caf: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-27 14:54 UTC by Piotr Kubaj
Modified: 2020-01-06 17:20 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (leres)


Attachments
patch (3.07 KB, patch)
2019-12-27 14:54 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (leres)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-12-27 14:54:32 UTC
Created attachment 210253 [details]
patch

netinet/ip.h needs sys/types.h:
/usr/include/netinet/ip.h:70:2: error: 'u_short' does not name a type; did you mean 'short'?
   70 |  u_short ip_sum;   /* checksum */
      |  ^~~~~~~
      |  short
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-12-27 18:01:31 UTC
A commit references this bug:

Author: leres
Date: Fri Dec 27 18:00:57 UTC 2019
New revision: 521016
URL: https://svnweb.freebsd.org/changeset/ports/521016

Log:
  devel/caf: Fix build on gcc architectures. As described in the PR
  submitted by Piotr Kubaj, netinet/ip.h needs sys/types.h.

  PR:		242908
  Submitted by:	Piotr Kubaj
  Approved by:	ler (mentor, implicit)

Changes:
  head/devel/caf/files/
  head/devel/caf/files/patch-libcaf__io_src_io_network_default__multiplexer.cpp
  head/devel/caf/files/patch-libcaf__io_src_io_network_ip__endpoint.cpp
  head/devel/caf/files/patch-libcaf__io_src_io_network_native__socket.cpp
Comment 2 Craig Leres freebsd_committer freebsd_triage 2019-12-27 18:08:57 UTC
Committed, thanks for the patch!

I also created an upsteam pull request: https://github.com/actor-framework/actor-framework/pull/1005

I have less interest in this port now that security/bro and security/zeek bundle specific versions of actor-framework (caf). Please accept my invitation to take over maintainership for this port if desired.
Comment 3 Craig Leres freebsd_committer freebsd_triage 2020-01-06 17:20:12 UTC
FYI, upstream committed the pull request to fix this issue.