Bug 243110 - net/ntopng: remove bashism and `md5sum` command
Summary: net/ntopng: remove bashism and `md5sum` command
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-05 10:42 UTC by Tomoyuki Sakurai
Modified: 2020-06-16 22:24 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+

Attachments
the patch to fix (1.20 KB, patch)
2020-01-05 10:42 UTC, Tomoyuki Sakurai 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomoyuki Sakurai 2020-01-05 10:42:37 UTC 
Created attachment 210464 [details]
the patch to fix

httpdocs/misc/ntopng-add-user.sh has `/bin/bash` and `md5sum`, which is not correct on FreeBSD.

the patch replaces them with correct ones.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2020-06-16 11:31:44 UTC 
Over to maintainer.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2020-06-16 13:32:16 UTC 
Thanks!

I'm looking at this.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-06-16 22:23:14 UTC 
A commit references this bug:

Author: madpilot
Date: Tue Jun 16 22:22:31 UTC 2020
New revision: 539383
URL: https://svnweb.freebsd.org/changeset/ports/539383

Log:
  Fix script to use md5 and not md5sum.

  PR:		243110
  Submitted by:	Tomoyuki Sakurai <trombik1973@gmail.com>

Changes:
  head/net/ntopng/Makefile
  head/net/ntopng/files/patch-httpdocs_misc_ntopng-add-user.sh
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2020-06-16 22:24:57 UTC 
I committed a fix.

There is no need to manually replace the shebang, this is already handled by USES=shebangfix.

Also there was another occurrence of md5sum in the script you fixed, I modified that too.